Refactor(eos_designs): Move debug vars dump to action plugin instead of it's own task

[ClausHolbechArista]

Change Summary

Move debug vars dump to action plugin instead of it's own task

Related Issue(s)

Increased run time after we removed tags since Ansible gathers all vars for every device before evaluating when on the task.

Component(s) name

arista.avd.eos_designs

Proposed changes

Move dump of hostvars to eos_designs_structured_config action plugin, since that already runs per device and has access to all vars.

How to test

Tested manually and compared output between devel and branch:

molecule converge -s eos_designs_unit_tests -- -e avd_eos_designs_debug="{{ true }}"

Note some reordering is expected where the internal data structures are built using sets.

Checklist

User Checklist

• N/A

Repository Checklist

• My code has been rebased from devel before I start
• I have read the CONTRIBUTING document.
• My change requires a change to the documentation and documentation have been updated accordingly.
• I have updated molecule CI testing accordingly. (check the box if not applicable)

[github-actions]

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4540
# Activate the virtual environment
source test-avd-pr-4540/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@refactor/eos_designs/move-debug-to-structured-config-action-plugin#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,refactor/eos_designs/move-debug-to-structured-config-action-plugin --force
# Optional: Install AVD examples
cd test-avd-pr-4540
ansible-playbook arista.avd.install_examples

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[carlbuchmann]

LGTM - tested in local repo... it's fast!