Doc: Porting guide review #4575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4575
# Activate the virtual environment
source test-avd-pr-4575/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/JulioPDX/ansible-avd.git@porting-guide-review#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/JulioPDX/ansible-avd.git#/ansible_collections/arista/avd/,porting-guide-review --force
# Optional: Install AVD examples
cd test-avd-pr-4575
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
the
type: documentation
gmuloc
reviewed
Oct 10, 2024
gmuloc
reviewed
Oct 10, 2024
gmuloc
reviewed
Oct 10, 2024
gmuloc
previously requested changes
Oct 10, 2024
JulioPDX
force-pushed
the
porting-guide-review
branch
from
79cfcb5
to
f858121
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
JulioPDX
force-pushed
the
porting-guide-review
branch
from
41396b8
to
d7e5961
Compare
JulioPDX
commented
Oct 11, 2024
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
github-actions
bot
added
role: eos_cli_config_gen
JulioPDX
force-pushed
the
porting-guide-review
branch
from
cf72105
to
48d6d89
Compare
github-actions
bot
removed
role: eos_cli_config_gen
Co-authored-by: Shivani-gslab <145646625+Shivani-gslab@users.noreply.github.com>
github-actions
bot
added
role: eos_cli_config_gen
|
ClausHolbechArista
approved these changes
Oct 18, 2024
gmuloc
pushed a commit
to gmuloc/avd
that referenced
this pull request
Oct 29, 2024
Co-authored-by: Carl Buchmann <carl.buchmann@arista.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Initial review over porting guide.
Component(s) name
Docs
Proposed changes
Minor grammar and example updates
How to test
View the docs locally for the most up-to-date build
Checklist
Repository Checklist