Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(eos_cli_config_gen)!: Reorder hardware and hardware-counter commands #4580

Merged
merged 5 commits into from
Oct 11, 2024

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Oct 10, 2024

Change Summary

cf title

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Regroup hardware-counters in hardware.j2 template
Move speed-groups

Verification on a real device

!
agent BLAH environment BLAH=BLAH
!
hardware port-group 1 select 1x-qsfp-dd(Et33)
!
hardware counter feature vlan-interface in
!
hardware access-list mechanism tcam
!
service routing configuration bgp no-equals-default
!

and

snmp-server community public ro
!
hardware speed-group2 serdes 10g
!
spanning-tree mode none
no spanning-tree vlan-id 4094

How to test

molecule

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc requested review from a team as code owners October 10, 2024 12:48
@gmuloc gmuloc added this to the v5.0.0 milestone Oct 10, 2024
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4580
# Activate the virtual environment
source test-avd-pr-4580/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@reorder-hw#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,reorder-hw --force
# Optional: Install AVD examples
cd test-avd-pr-4580
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Oct 10, 2024
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Oct 11, 2024
Copy link

sonarcloud bot commented Oct 11, 2024

Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann merged commit 72226dc into aristanetworks:devel Oct 11, 2024
43 checks passed
nathanmusser pushed a commit to nathanmusser/avd that referenced this pull request Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Refactor(eos_cli_config_gen)! state: CI Updated CI scenario have been updated in the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants