-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor(eos_cli_config_gen)!: Reorder hardware and hardware-counter commands #4580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4580
# Activate the virtual environment
source test-avd-pr-4580/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@reorder-hw#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,reorder-hw --force
# Optional: Install AVD examples
cd test-avd-pr-4580
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
the
state: CI Updated
CI scenario have been updated in the PR
label
Oct 10, 2024
Vibhu-gslab
force-pushed
the
reorder-hw
branch
from
October 11, 2024 07:09
43d09b0
to
f96d996
Compare
ClausHolbechArista
approved these changes
Oct 11, 2024
ClausHolbechArista
added
the
one approval
This PR has one approval and is only missing one more.
label
Oct 11, 2024
Quality Gate passedIssues Measures |
carlbuchmann
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
one approval
This PR has one approval and is only missing one more.
rn: Refactor(eos_cli_config_gen)!
state: CI Updated
CI scenario have been updated in the PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
cf title
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
Regroup hardware-counters in hardware.j2 template
Move speed-groups
Verification on a real device
and
How to test
molecule
Checklist
Repository Checklist