Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(eos_designs): Fix the Invalid command of vxlan vxlan vlan <vlan_id> flood vtep #4592

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

MaheshGSLAB
Copy link
Contributor

Change Summary

Fix the Invalid command of vxlan vxlan vlan <vlan_id> flood vtep.

Related Issue(s)

Fixes #4513

Component(s) name

arista.avd.eos_designs

Proposed changes

flood_vteps rendering empty lists of vteps hence added the condition to be not empty.

How to test

Run molecule

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@MaheshGSLAB MaheshGSLAB self-assigned this Oct 15, 2024
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4592
# Activate the virtual environment
source test-avd-pr-4592/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/MaheshGSLAB/ansible-avd.git@issue-4513#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/MaheshGSLAB/ansible-avd.git#/ansible_collections/arista/avd/,issue-4513 --force
# Optional: Install AVD examples
cd test-avd-pr-4592
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Oct 15, 2024
@gmuloc gmuloc added this to the v5.0.0 milestone Oct 15, 2024
Copy link
Contributor

@Shivani-gslab Shivani-gslab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Shivani-gslab Shivani-gslab marked this pull request as ready for review October 16, 2024 08:57
@Shivani-gslab Shivani-gslab requested review from a team as code owners October 16, 2024 08:57
Co-authored-by: Guillaume Mulocher <gmulocher@arista.com>
Copy link

sonarcloud bot commented Oct 16, 2024

@gmuloc gmuloc merged commit 3716663 into aristanetworks:devel Oct 16, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Fix(eos_designs) state: CI Updated CI scenario have been updated in the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug(eos_designs): Invalid command of vxlan vxlan vlan <vlan_id> flood vtep rendered
4 participants