-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(eos_designs): Fix the Invalid command of vxlan vxlan vlan <vlan_id> flood vtep
#4592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4592
# Activate the virtual environment
source test-avd-pr-4592/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/MaheshGSLAB/ansible-avd.git@issue-4513#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/MaheshGSLAB/ansible-avd.git#/ansible_collections/arista/avd/,issue-4513 --force
# Optional: Install AVD examples
cd test-avd-pr-4592
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
the
state: CI Updated
CI scenario have been updated in the PR
label
Oct 15, 2024
Shivani-gslab
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Vibhu-gslab
force-pushed
the
issue-4513
branch
from
October 16, 2024 09:00
6717a32
to
1c5de8f
Compare
gmuloc
reviewed
Oct 16, 2024
python-avd/pyavd/_eos_designs/structured_config/network_services/vxlan_interface.py
Outdated
Show resolved
Hide resolved
gmuloc
reviewed
Oct 16, 2024
python-avd/pyavd/_eos_designs/structured_config/network_services/vxlan_interface.py
Outdated
Show resolved
Hide resolved
Vibhu-gslab
approved these changes
Oct 16, 2024
Vibhu-gslab
force-pushed
the
issue-4513
branch
from
October 16, 2024 10:50
1c5de8f
to
695d474
Compare
Co-authored-by: Guillaume Mulocher <gmulocher@arista.com>
Quality Gate passedIssues Measures |
gmuloc
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Fix the Invalid command of
vxlan vxlan vlan <vlan_id> flood vtep
.Related Issue(s)
Fixes #4513
Component(s) name
arista.avd.eos_designs
Proposed changes
flood_vteps rendering empty lists of vteps hence added the condition to be not empty.
How to test
Run molecule
Checklist
User Checklist
Repository Checklist