Feat(eos_cli_config_gen): Added support for neighbor x.x.x.x encapsulation mpls next-hop-self source-intf <source-interface>
#4608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4608
# Activate the virtual environment
source test-avd-pr-4608/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/MaheshGSLAB/ansible-avd.git@issue-4243#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/MaheshGSLAB/ansible-avd.git#/ansible_collections/arista/avd/,issue-4243 --force
# Optional: Install AVD examples
cd test-avd-pr-4608
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
role: eos_cli_config_gen
laxmikantchintakindi
approved these changes
Oct 18, 2024
Vibhu-gslab
reviewed
Oct 18, 2024
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/router-bgp.j2
Outdated
Show resolved
Hide resolved
ClausHolbechArista
previously requested changes
Oct 18, 2024
Vibhu-gslab
approved these changes
Oct 21, 2024
ClausHolbechArista
dismissed
their stale review
5.0 is out so this can be reviewed and merged
ClausHolbechArista
added
the
one approval
gmuloc
requested changes
Oct 28, 2024
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/router_bgp.schema.yml
Show resolved
Hide resolved
gmuloc
approved these changes
Oct 28, 2024
|
gmuloc
pushed a commit
to gmuloc/avd
that referenced
this pull request
Oct 29, 2024
…lation mpls next-hop-self source-intf <source-interface>` (aristanetworks#4608)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Added support for
neighbor x.x.x.x encapsulation mpls next-hop-self source-intf <source-interface>Related Issue(s)
Fixes #4243
Component(s) name
`arista.avd.eos_cli_config_gen
Proposed changes
Added support for
neighbor x.x.x.x encapsulation mpls next-hop-self source-intf <source-interface>How to test
Run molecule
Checklist
User Checklist
Repository Checklist