Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Adding improved model for interface link tracking groups #4610

Merged
merged 14 commits into from
Nov 11, 2024

Conversation

Vibhu-gslab
Copy link
Contributor

@Vibhu-gslab Vibhu-gslab commented Oct 17, 2024

Change Summary

Introducing new model for link tracking group which supports only one direction for an interface

Related Issue(s)

Fixes #4584

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Adding a new model

How to test

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4610
# Activate the virtual environment
source test-avd-pr-4610/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Vibhu-gslab/avd.git@4584#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Vibhu-gslab/avd.git#/ansible_collections/arista/avd/,4584 --force
# Optional: Install AVD examples
cd test-avd-pr-4610
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Oct 17, 2024
@Vibhu-gslab Vibhu-gslab changed the title Refactor(eos_cli_config_gen): Change the data model to support only one direction in link tracking group for an interface Refactor(eos_cli_config_gen, eos_designs): Change the data model to support only one direction in link tracking group for an interface Oct 17, 2024
@Vibhu-gslab Vibhu-gslab changed the title Refactor(eos_cli_config_gen, eos_designs): Change the data model to support only one direction in link tracking group for an interface Refactor(eos_cli_config_gen, eos_designs): Link tracking group supports only one direction for an interface Oct 17, 2024
@gmuloc gmuloc added this to the v5.0.0 milestone Oct 17, 2024
@ClausHolbechArista ClausHolbechArista removed this from the v5.0.0 milestone Oct 18, 2024
@Vibhu-gslab Vibhu-gslab changed the title Refactor(eos_cli_config_gen, eos_designs): Link tracking group supports only one direction for an interface Refactor(eos_cli_config_gen): Adding new model for link tracking group which supports only one direction for an interface Oct 18, 2024
Copy link
Contributor

@Shivani-gslab Shivani-gslab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Vibhu-gslab Vibhu-gslab marked this pull request as draft November 6, 2024 11:20
@Vibhu-gslab Vibhu-gslab marked this pull request as ready for review November 7, 2024 11:18
@github-actions github-actions bot added the state: conflict PR with conflict label Nov 11, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the state: conflict PR with conflict label Nov 11, 2024
@ClausHolbechArista ClausHolbechArista changed the title Feat(eos_cli_config_gen): Adding new improved model for interface link tracking groups Feat(eos_cli_config_gen): Adding improved model for interface link tracking groups Nov 11, 2024
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please review open comments

Copy link

sonarcloud bot commented Nov 11, 2024

@ClausHolbechArista ClausHolbechArista merged commit 889906f into aristanetworks:devel Nov 11, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot configure both upstream and downstream in link tracking group for the same interface
5 participants