Feat(eos_cli_config_gen): Expand CLI to support DualEncap MH EVPN GW requirements

[colinmacgiolla]

Change Summary

This PR addresses what is described in #4604 - allow the remote domain, and evpn segments to be defined under the BGP AF EVPN

Related Issue(s)

Fixes #4604

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

router_bgp:
   address_family_evpn:
      domain_identifier: <string>
      domain_identifier_remote: <string>
      evpn_ethernet_segment:
         - domain: <all | local | remote>
           identifier: <segment id>
           route_target: <EVPN Route Target for ESI with format xx:xx:xx:xx:xx:xx.>

How to test

Molecule tests updated and compared with switch running 4.32.2F.

Checklist

User Checklist

• N/A

Repository Checklist

• My code has been rebased from devel before I start
• I have read the CONTRIBUTING document.
• My change requires a change to the documentation and documentation have been updated accordingly.
• I have updated molecule CI testing accordingly. (check the box if not applicable)

[github-actions]

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4613
# Activate the virtual environment
source test-avd-pr-4613/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/colinmacgiolla/ansible-avd.git@EVPN-MH-Dual-Encap-GW#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/colinmacgiolla/ansible-avd.git#/ansible_collections/arista/avd/,EVPN-MH-Dual-Encap-GW --force
# Optional: Install AVD examples
cd test-avd-pr-4613
ansible-playbook arista.avd.install_examples

[colinmacgiolla]

This is more to ensure that it renders in the correct order

[colinmacgiolla]

Yeah, I did consider that - I was just thinking if we add more domains in the future, it relying on sorting alphabetically may not keep working. I'll updated

…

On Fri, 18 Oct 2024 at 11:48, laxmikantchintakindi ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/router-bgp.j2 <#4613 (comment)>: > @@ -971,6 +974,22 @@ router bgp {{ router_bgp.as }} {% if router_bgp.address_family_evpn.route.import_overlay_index_gateway is arista.avd.defined(true) %} route import overlay-index gateway {% endif %} +{% if router_bgp.address_family_evpn.evpn_ethernet_segment is arista.avd.defined %} +{% set domain_list = ['all', 'local','remote'] %} I deleted my comment by mistake. I think you can use arista.avd.natural_sort("domain"). — Reply to this email directly, view it on GitHub <#4613 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKNXQATHBNJBRRRHOPWWTFDZ4DRPLAVCNFSM6AAAAABQFUACO6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNZXG42TONRXGQ> . You are receiving this because you were assigned.Message ID: ***@***.***>

[Shivani-gslab]

One minor suggestion, rest LGTM!

[ClausHolbechArista]

Blocking until 5.0 is out

5.0 is out so this can be reviewed and merged

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud