Feat(eos_cli_config_gen): Add support for mac timestamp header command

[laxmikantchintakindi]

Change Summary

Add support for mac timestamp header command.

Related Issue(s)

Fixes #4331

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

mac timestamp header is a flag you can enable on an interface in EOS.

interface <str>
    mac timestamp header

How to test

Checklist

User Checklist

• N/A

Repository Checklist

• My code has been rebased from devel before I start
• I have read the CONTRIBUTING document.
• My change requires a change to the documentation and documentation have been updated accordingly.
• I have updated molecule CI testing accordingly. (check the box if not applicable)

[github-actions]

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4635
# Activate the virtual environment
source test-avd-pr-4635/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@feat/mac-timestamp-header#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,feat/mac-timestamp-header --force
# Optional: Install AVD examples
cd test-avd-pr-4635
ansible-playbook arista.avd.install_examples

[alexeygorbunov]

TAP Aggregation tool ports seem to support 3 different timestamp-ing modes (depending on a platform):

• header - on platforms like 7280E/Rs and 7500E/Rs
• before-fcs & replace-fcs on platforms like 7150s

EOS CLI (checked on 4.32.1F) supports all three under interface configuration mode:
IntfConfigMode: [no|default] mac timestamp ( before-fcs | replace-fcs | header )

  before-fcs   insert timestamp before fcs field
  replace-fcs  replace fcs field with timestamp
  header    insert timestamp in Ethernet header

Would it make sense to cover all three available options?

  type: dict
  keys:
    ethernet_interfaces:
      items:
        keys:
+        mac_timestamp:
+          type: str
+          valid_values: ["before-fcs", "replace-fcs", "header"]

P.S. Although interface-level mac timestamp <str> commands are only active on tool port of the EoS switch running in TAP aggregation mode - EoS allows to configure 'mac timestamp ' event if these conditions are not met, so probably we can skip interface mode validations within schema and can let CV/EOS to highlight warnings (based on workspace build validations) if platform|port_mode|etc is not matching.

[laxmikantchintakindi]

TAP Aggregation tool ports seem to support 3 different timestamp-ing modes (depending on a platform):

• header - on platforms like 7280E/Rs and 7500E/Rs
• before-fcs & replace-fcs on platforms like 7150s

EOS CLI (checked on 4.32.1F) supports all three under interface configuration mode: IntfConfigMode: [no|default] mac timestamp ( before-fcs | replace-fcs | header )

  before-fcs   insert timestamp before fcs field
  replace-fcs  replace fcs field with timestamp
  header    insert timestamp in Ethernet header

Would it make sense to cover all three available options?

  type: dict
  keys:
    ethernet_interfaces:
      items:
        keys:
+        mac_timestamp:
+          type: str
+          valid_values: ["before-fcs", "replace-fcs", "header"]

P.S. Although interface-level mac timestamp <str> commands are only active on tool port of the EoS switch running in TAP aggregation mode - EoS allows to configure 'mac timestamp ' event if these conditions are not met, so probably we can skip interface mode validations within schema and can let CV/EOS to highlight warnings (based on workspace build validations) if platform|port_mode|etc is not matching.

Fixed. Thanks.

[alexeygorbunov]

LGTM

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud