-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_cli_config_gen): Add BFD Slow-Timer Knob #4718
Merged
gmuloc
merged 4 commits into
aristanetworks:devel
from
ccsnw:Feat(eos_cli_config_gen)-Add_bfd_slow_timer_knob
Nov 13, 2024
Merged
Feat(eos_cli_config_gen): Add BFD Slow-Timer Knob #4718
gmuloc
merged 4 commits into
aristanetworks:devel
from
ccsnw:Feat(eos_cli_config_gen)-Add_bfd_slow_timer_knob
Nov 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4718
# Activate the virtual environment
source test-avd-pr-4718/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ccsnw/ansible-avd.git@Feat(eos_cli_config_gen)-Add_bfd_slow_timer_knob#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ccsnw/ansible-avd.git#/ansible_collections/arista/avd/,Feat(eos_cli_config_gen)-Add_bfd_slow_timer_knob --force
# Optional: Install AVD examples
cd test-avd-pr-4718
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
labels
Nov 13, 2024
ccsnw
changed the title
Feat(eos_cli_config_gen)-Add BFD Slow-Timer Knob
Feat(eos_cli_config_gen): Add BFD Slow-Timer Knob
Nov 13, 2024
Shivani-gslab
previously requested changes
Nov 13, 2024
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/router_bfd.schema.yml
Show resolved
Hide resolved
ccsnw
force-pushed
the
Feat(eos_cli_config_gen)-Add_bfd_slow_timer_knob
branch
from
November 13, 2024 11:19
ea386f1
to
04edebc
Compare
Vibhu-gslab
previously requested changes
Nov 13, 2024
ansible_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/host1.cfg
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/host1.md
Outdated
Show resolved
Hide resolved
ClausHolbechArista
requested changes
Nov 13, 2024
ansible_collections/arista/avd/molecule/eos_cli_config_gen/intended/configs/host1.cfg
Outdated
Show resolved
Hide resolved
ClausHolbechArista
approved these changes
Nov 13, 2024
gmuloc
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
gmuloc
dismissed stale reviews from Vibhu-gslab and Shivani-gslab
November 13, 2024 13:14
Changes addressed
gmuloc
added
the
one approval
This PR has one approval and is only missing one more.
label
Nov 13, 2024
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
one approval
This PR has one approval and is only missing one more.
rn: Feat(eos_cli_config_gen)
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Adding Slow-Timer knob to BFD config.
Fixing two minor typos in existing J2 template (2 space where only 1 space should be used)
Related Issue(s)
Fixes #<N/A>
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
Adding additional knob to configure slow-timer value in BFD
router_bfd:
slow_timer:
description: Rate in milliseconds.
type: int
min: 2000
max: 60000
How to test
Molecule Test added
Checklist
User Checklist
Repository Checklist