Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Add BFD Slow-Timer Knob #4718

Conversation

ccsnw
Copy link
Contributor

@ccsnw ccsnw commented Nov 13, 2024

Change Summary

Adding Slow-Timer knob to BFD config.
Fixing two minor typos in existing J2 template (2 space where only 1 space should be used)

Related Issue(s)

Fixes #<N/A>

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Adding additional knob to configure slow-timer value in BFD

router_bfd:

slow_timer:
description: Rate in milliseconds.
type: int
min: 2000
max: 60000

How to test

Molecule Test added

Checklist

User Checklist

  • Have checked eos cli order for command
  • Documentation not updated (minor knob)

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • [o] My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@ccsnw ccsnw requested review from a team as code owners November 13, 2024 08:18
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4718
# Activate the virtual environment
source test-avd-pr-4718/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ccsnw/ansible-avd.git@Feat(eos_cli_config_gen)-Add_bfd_slow_timer_knob#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ccsnw/ansible-avd.git#/ansible_collections/arista/avd/,Feat(eos_cli_config_gen)-Add_bfd_slow_timer_knob --force
# Optional: Install AVD examples
cd test-avd-pr-4718
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Nov 13, 2024
@ccsnw ccsnw changed the title Feat(eos_cli_config_gen)-Add BFD Slow-Timer Knob Feat(eos_cli_config_gen): Add BFD Slow-Timer Knob Nov 13, 2024
@ccsnw ccsnw force-pushed the Feat(eos_cli_config_gen)-Add_bfd_slow_timer_knob branch from ea386f1 to 04edebc Compare November 13, 2024 11:19
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmuloc gmuloc dismissed stale reviews from Vibhu-gslab and Shivani-gslab November 13, 2024 13:14

Changes addressed

@gmuloc gmuloc added the one approval This PR has one approval and is only missing one more. label Nov 13, 2024
Copy link

sonarcloud bot commented Nov 13, 2024

@gmuloc gmuloc merged commit 5300bf6 into aristanetworks:devel Nov 13, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants