Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(eos_cli_config_gen): Fix the invalid configuration of vpn-route in export direction for router bgp vrf #4765

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

MaheshGSLAB
Copy link
Contributor

Change Summary

Fix the vrf-route for route-target export in router bgp vrf.

Router BGP VRF configuration for route-target should have vrf-route in one direction(export) and vpn-route in the other direction(import) but right now bot have vpn-route. Hence it render the below configuration.

route-target export vpn-ipv6 rcf RT_IMPORT_AF_RCF() vpn-route filter-rcf RT_IMPORT_AF_RCF_FILTER().

I should render below configuration.
route-target export vpn-ipv6 rcf RT_IMPORT_AF_RCF() vrf-route filter-rcf RT_IMPORT_AF_RCF_FILTER()

Related Issue(s)

Fixes #4731

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Updated the j2 template to render the vrf-route instead of vpn-route for export direction in router bgp vrf.

How to test

Run molecule and deploy the config on lab.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@MaheshGSLAB MaheshGSLAB self-assigned this Nov 27, 2024
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4765
# Activate the virtual environment
source test-avd-pr-4765/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/MaheshGSLAB/ansible-avd.git@issue-4731#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/MaheshGSLAB/ansible-avd.git#/ansible_collections/arista/avd/,issue-4731 --force
# Optional: Install AVD examples
cd test-avd-pr-4765
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Nov 27, 2024
@MaheshGSLAB MaheshGSLAB changed the title Fix(eos_cli_config_gen): Fix the vrf-route for route-target export in router bgp vrf Fix(eos_cli_config_gen): Fix the invalid configuration of vpn-route in export direction for router bgp vrf Nov 27, 2024
@MaheshGSLAB MaheshGSLAB marked this pull request as ready for review November 29, 2024 13:38
@MaheshGSLAB MaheshGSLAB requested review from a team as code owners November 29, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: CI Updated CI scenario have been updated in the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug(eos_cli_config_gen): route-target export should have vrf-route instead of vpn-route for router bgp
1 participant