Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update device port channel documentation #485

Merged
merged 4 commits into from
Dec 15, 2020
Merged

Update device port channel documentation #485

merged 4 commits into from
Dec 15, 2020

Conversation

ksator
Copy link
Contributor

@ksator ksator commented Dec 13, 2020

Change Summary

Update device port channel documentation

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Documentation content changes
  • Other (please describe):

Related Issue(s)

#272

Component(s) name

role eos_cli_config_gen
document template port-channel-interfaces.j2

Proposed changes

The template was broken due to a typo, it is now fixed.
it was using | -------- ! ------- | instead of | ------- | ------ |

Added native-vlan to the documentation.

How to test

Execute the role eos_cli_config_gen

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed (pre-commit, make linting and make sanity-lint).
  • I have updated molecule CI testing accordingly

@ksator ksator added type: documentation Improvements or additions to documentation role: eos_cli_config_gen issue related to eos_cli_config_gen role labels Dec 13, 2020
@ksator ksator self-assigned this Dec 13, 2020
@ksator ksator marked this pull request as ready for review December 13, 2020 16:02
@ksator
Copy link
Contributor Author

ksator commented Dec 13, 2020

  • fixed the table
  • added native vlan in the L2 report
  • created an IPv4 table
  • created an IPv6 table

@ksator ksator linked an issue Dec 14, 2020 that may be closed by this pull request
@aphillipps aphillipps merged commit d6a573e into aristanetworks:devel Dec 15, 2020
@ksator ksator deleted the issue/272 branch December 16, 2020 06:41
@titom73 titom73 added this to the v2.0.0rc1 milestone Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port-channel Interface Documentation Template to be completed
3 participants