Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bgp: docu: afi ipv4 neighbors supoprt routemaps, too #490

Merged
merged 1 commit into from
Dec 15, 2020
Merged

bgp: docu: afi ipv4 neighbors supoprt routemaps, too #490

merged 1 commit into from
Dec 15, 2020

Conversation

c-po
Copy link
Contributor

@c-po c-po commented Dec 15, 2020

Change Summary

Simple documentation update for BGP

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Documentation content changes
  • Other (please describe):

Related Issue(s)

Component(s) name

BGP

Proposed changes

How to test

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed (pre-commit, make linting and make sanity-lint).
  • I have updated molecule CI testing accordingly

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: Documentation role Updated labels Dec 15, 2020
titom73
titom73 approved these changes Dec 15, 2020
View reviewed changes
Copy link
Contributor

@titom73 titom73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the PR

@titom73 titom73 merged commit 81552c9 into aristanetworks:devel Dec 15, 2020
@titom73 titom73 added this to the v1.1.3 milestone Dec 15, 2020
@carlbuchmann carlbuchmann modified the milestones: v1.1.3, v1.2.0 Dec 16, 2020
@c-po c-po deleted the bgp-docu-update branch November 8, 2021 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@titom73 titom73 titom73 approved these changes

@carlbuchmann carlbuchmann Awaiting requested review from carlbuchmann

@aphillipps aphillipps Awaiting requested review from aphillipps

Assignees

@c-po c-po

Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role state: Documentation role Updated
Projects
None yet
Milestone
v2.0.0rc1
Development

Successfully merging this pull request may close these issues.
3 participants
@c-po @titom73 @carlbuchmann