Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IGMP snooping documentation fix #519

Merged
merged 5 commits into from
Dec 21, 2020
Merged

IGMP snooping documentation fix #519

merged 5 commits into from
Dec 21, 2020

Conversation

onurgashi
Copy link
Contributor

@onurgashi onurgashi commented Dec 20, 2020 •
edited by carlbuchmann
Loading

Change Summary

Fixes documentation for IGMP snooping.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Documentation content changes
  • Other (please describe):

Related Issue(s)

Fixes #298

Component(s) name

eos_cli_config_gen
molecule

Proposed changes

How to test

Molecule and HW

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed (pre-commit, make linting and make sanity-lint).
  • I have updated molecule CI testing accordingly

@onurgashi onurgashi added the type: documentation Improvements or additions to documentation label Dec 20, 2020
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Dec 20, 2020
titom73
titom73 approved these changes Dec 21, 2020
View reviewed changes
Copy link
Contributor

@titom73 titom73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@titom73 titom73 merged commit 9f4555a into aristanetworks:devel Dec 21, 2020
@onurgashi onurgashi mentioned this pull request Jan 6, 2021
Closed
@carlbuchmann carlbuchmann added this to the v1.2.0 milestone Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@titom73 titom73 titom73 approved these changes

@ksator ksator Awaiting requested review from ksator

@carlbuchmann carlbuchmann Awaiting requested review from carlbuchmann

@aphillipps aphillipps Awaiting requested review from aphillipps

Assignees

@onurgashi onurgashi

Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated type: documentation Improvements or additions to documentation
Projects
None yet
Milestone
v2.0.0rc1
Development

Successfully merging this pull request may close these issues.

update documentation/ip-igmp-snooping.j2
3 participants
@onurgashi @titom73 @carlbuchmann