Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include default VRF in mgmt api for eos_l3ls_evpn #533

Merged
merged 3 commits into from
Dec 28, 2020
Merged

Include default VRF in mgmt api for eos_l3ls_evpn #533

merged 3 commits into from
Dec 28, 2020

Conversation

onurgashi
Copy link
Contributor

@onurgashi onurgashi commented Dec 22, 2020 •
edited by titom73
Loading

Change Summary

Fixes the for loop to include the default VRF, required for ACL definition in mgmt api.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Documentation content changes
  • Other (please describe):

Related Issue(s)

Fixes #529

Component(s) name

eos_l3ls_evpn
molecule

Proposed changes

How to test

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed (pre-commit, make linting and make sanity-lint).
  • I have updated molecule CI testing accordingly

@onurgashi onurgashi added type: bug Something isn't working role: eos_l3ls_evpn issue related to eos_l3ls_evpn role state: Documentation role Updated labels Dec 22, 2020
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR labels Dec 22, 2020
titom73
titom73 approved these changes Dec 28, 2020
View reviewed changes
Copy link
Contributor

@titom73 titom73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@titom73 titom73 merged commit ab50b04 into aristanetworks:devel Dec 28, 2020
@titom73 titom73 added this to the v1.2.0 milestone Dec 28, 2020
@titom73
Copy link
Contributor

titom73 commented Jan 26, 2021

cherry-picked to pre-release branch: https://github.com/titom73/ansible-avd/tree/release-v1.1.3-preparation

@titom73 titom73 mentioned this pull request Jan 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@titom73 titom73 titom73 approved these changes

@carlbuchmann carlbuchmann Awaiting requested review from carlbuchmann

@aphillipps aphillipps Awaiting requested review from aphillipps

Assignees

@onurgashi onurgashi

Labels
cherry-pick role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_l3ls_evpn issue related to eos_l3ls_evpn role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated type: bug Something isn't working
Projects
None yet
Milestone
v2.0.0rc1
Development

Successfully merging this pull request may close these issues.

Update mgmt api j2 to support acl in default vrf
3 participants
@onurgashi @titom73 @carlbuchmann