Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

svi and l2vlan keys to check and tested as int #536

Merged
merged 4 commits into from
Dec 24, 2020
Merged

svi and l2vlan keys to check and tested as int #536

merged 4 commits into from
Dec 24, 2020

Conversation

onurgashi
Copy link
Contributor

Change Summary

With this change we can use both strings and integer under l2vlan and svi and do the checks correctly.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Documentation content changes
  • Other (please describe):

Related Issue(s)

Component(s) name

eos_l3ls_evpn

Proposed changes

Anything matching svi or l2vlan under any if condition will have | int

svi | int in leaf.svi
l2vlan | int in leaf.l2vlans

How to test

Tested in venv and created molecule test case, validated both before and after.

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed (pre-commit, make linting and make sanity-lint).
  • I have updated molecule CI testing accordingly

@onurgashi onurgashi added type: bug Something isn't working role: eos_l3ls_evpn issue related to eos_l3ls_evpn role labels Dec 23, 2020
@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Dec 23, 2020
@onurgashi onurgashi changed the title Svi and l2vlan keys to check and tested to as int Svi and l2vlan keys to check and tested as int Dec 23, 2020
@onurgashi onurgashi changed the title Svi and l2vlan keys to check and tested as int svi and l2vlan keys to check and tested as int Dec 23, 2020
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@carlbuchmann carlbuchmann merged commit e8e344c into aristanetworks:devel Dec 24, 2020
@titom73 titom73 added this to the v2.0.0rc1 milestone Jan 21, 2021
@titom73
Copy link
Contributor

titom73 commented Jan 26, 2021

@titom73 titom73 mentioned this pull request Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick role: eos_l3ls_evpn issue related to eos_l3ls_evpn role state: CI Updated CI scenario have been updated in the PR type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants