Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix l3ls role documentation about igmp snooping #545

Merged
merged 1 commit into from
Dec 28, 2020
Merged

Fix l3ls role documentation about igmp snooping #545

merged 1 commit into from
Dec 28, 2020

Conversation

ksator
Copy link
Contributor

@ksator ksator commented Dec 28, 2020

Change Summary

Fix l3ls role documentation about igmp snooping

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Documentation content changes
  • Other (please describe):

Related Issue(s)

#540

Component(s) name

l3ls role
readme file

Proposed changes

Fix l3ls role documentation about igmp snooping

Current doc

fabric_name: < Fabric_Name >
# Disable IGMP snooping at fabric level.
# If set, it overrides per vlan settings
default_igmp_snooping: < boolean | default -> true >

But according to the code and my tests it is not default_igmp_snooping it is default_igmp_snooping_enabled:

  • default_igmp_snooping_enabled (at the root level)
  • igmp_snooping_enabled (under l3leaf/default or l3leaf/nodes/xxx) (templates/evpn-fabric-l3leaf-yml.j2)
  • igmp_snooping_enabled (under l2leaf/default or l2leaf/nodes/xxx) (templates/evpn-fabric-l2leaf-yml.j2)
  • igmp_snooping_enabled (under tenants/vrfs/svis) (templates/tenant_evpn_vxlan/leaf-tenant-igmp-snooping.j2)
  • igmp_snooping_enabled (under tenants/l2vlans) (templates/tenant_evpn_vxlan/leaf-tenant-igmp-snooping.j2)

How to test

Example:

fabric_name: DC1_FABRIC
default_igmp_snooping_enabled: false
l3leaf:
  defaults:
     igmp_snooping_enabled: true
  node_groups:
    DC1_LEAF1:
      igmp_snooping_enabled: false
tenants:
  Tenant_A:
    mac_vrf_vni_base: 10000
    vrfs:
      Tenant_A_OP_Zone:
        svis:
          12:
            name: Tenant_A_OP_Zone_Test
            tags: [app]
            enabled: true
            igmp_snooping_enabled: false
            ip_address_virtual: 172.16.112.1/24
    l2vlans:
      160:
        vni_override: 55160
        name: Tenant_A_VMOTION
        tags: [vmotion]
        igmp_snooping_enabled: false
      161:
        name: Tenant_A_NFS
        tags: [nfs]
        igmp_snooping_enabled: true

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed (pre-commit, make linting and make sanity-lint).
  • I have updated molecule CI testing accordingly

@ksator ksator added type: documentation Improvements or additions to documentation role: eos_l3ls_evpn issue related to eos_l3ls_evpn role labels Dec 28, 2020
@ksator ksator self-assigned this Dec 28, 2020
@ksator ksator linked an issue Dec 28, 2020 that may be closed by this pull request
@titom73 titom73 added this to the v1.2.0 milestone Dec 28, 2020
Copy link
Contributor

@titom73 titom73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@titom73 titom73 merged commit 24b23ba into aristanetworks:devel Dec 28, 2020
@titom73
Copy link
Contributor

titom73 commented Jan 26, 2021

@titom73 titom73 mentioned this pull request Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick role: eos_l3ls_evpn issue related to eos_l3ls_evpn role state: Documentation role Updated type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

default_igmp_snooping in l3ls_evpn
3 participants