Fix bug SS and Overlay C support bgp max-path/ecmp

[onurgashi]

Change Summary

This fixes the bug so we factor in the Super Spine and Overlay Controller to configure bgp max-paths and ecmp

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Code style update (formatting, renaming)
• Refactoring (no functional changes)
• Documentation content changes
• Other (please describe):

Related Issue(s)

Fixes #537

Component(s) name

eos_l3ls_evpn

Proposed changes

super-spine-router-bgp-base.j2

{%         if bgp_maximum_paths is defined and bgp_maximum_paths is not none and bgp_ecmp is defined and bgp_ecmp is not none %}
    - maximum-paths {{ bgp_maximum_paths }} ecmp {{ bgp_ecmp }}
{%         elif bgp_maximum_paths is defined and bgp_maximum_paths is not none %}
    - maximum-paths {{ bgp_maximum_paths }}
{%         else %}
    - maximum-paths {{ super_spine.nodes | length }} ecmp {{ super_spine.nodes | length }}
{%         endif %}

overlay-controller-router-bgp-base.j2

{%         if bgp_maximum_paths is defined and bgp_maximum_paths is not none and bgp_ecmp is defined and bgp_ecmp is not none %}
    - maximum-paths {{ bgp_maximum_paths }} ecmp {{ bgp_ecmp }}
{%         elif bgp_maximum_paths is defined and bgp_maximum_paths is not none %}
    - maximum-paths {{ bgp_maximum_paths }}
{%         else %}
    - maximum-paths {{ switch.remote_switches_interfaces | length }} ecmp {{ switch.remote_switches_interfaces | length }}
{%         endif %}

How to test

Default takes into account the math, if we use the knobs, we override the math

bgp_maximum_paths: 4
bgp_ecmp: 4

Super Spine

router bgp 65001
   router-id 192.168.100.1
   no bgp default ipv4-unicast
   distance bgp 20 200 200
   graceful-restart restart-time 300
   graceful-restart
   maximum-paths 4 ecmp 4

Route Server

router bgp 65100
   router-id 172.32.250.1
   no bgp default ipv4-unicast
   distance bgp 20 200 200
   graceful-restart restart-time 300
   graceful-restart
   maximum-paths 4 ecmp 4

Checklist:

• I have read the CONTRIBUTING document.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• All new and existing tests passed (pre-commit, make linting and make sanity-lint).
• I have updated molecule CI testing accordingly

[carlbuchmann]

@onur @ClausHolbechArista - can you produce test artifacts here: https://github.com/ClausHolbechArista/claus-l3ls-dev

[carlbuchmann]

looks good! - ok merge once tested in with https://github.com/ClausHolbechArista/claus-l3ls-dev

[ClausHolbechArista]

Rebased and tested.
Test without this fix:
https://github.com/ClausHolbechArista/claus-l3ls-dev/commit/c0b8b8c150bebf594458d109604fbcbb602acf22
Test after adding this fix:
https://github.com/ClausHolbechArista/claus-l3ls-dev/commit/569bc1951253e971db109cc84c353c773af05773