Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance logging event, tacacs timeout and platform sand multicast replication features #650

Closed
wants to merge 9 commits into from
Closed

Enhance logging event, tacacs timeout and platform sand multicast replication features #650

wants to merge 9 commits into from

Conversation

aphillipps
Copy link
Contributor

@aphillipps aphillipps commented Jan 21, 2021 •
edited
Loading

Change Summary

3 Configuration Adds-on in Eos_cli_config_gen: logging event, tacacs timeout and platform sand multicast replication

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Documentation content changes
  • Other (please describe):

Related Issue(s)

Component(s) name

Eos_cli_config_gen

Proposed changes

Added support for the following configuration lines under ethernet and port-channel interfaces:

  • no logging event link-status
  • logging event link-status

Added support for the following configuration lines for Sand platforms:

  • platform sand multicast replication default fabric-egress
  • platform sand multicast replication default ingress

Added support for the timeout configuration on a tacacs server:

  • tacacs-server host x.x.x.x timeout xx

How to test

Here are examples for the 3 new features:

  1. No logging event:
  Port-Channel3:
    logging:
      event:
        link_status: false
  1. Sand multicast replication type
platform:
  sand:
    multicast_replication:
      default: fabric-egress
  1. Timeout for Tacacs:
aaa_server_groups:
  - name: TACACS
    type: tacacs+
    servers:
      - server: 10.10.10.157
        vrf: mgt
      - server: 10.10.10.249

Checklist:

  • My code has been rebased from release v1.1.x before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have updated molecule CI testing accordingly
  • All new and existing tests passed (pre-commit, make linting and make sanity-lint).

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR type: documentation Improvements or additions to documentation labels Jan 21, 2021
@aphillipps aphillipps added this to the v1.1.3 milestone Jan 21, 2021
@carlbuchmann carlbuchmann modified the milestones: v1.1.3, v2.0.0rc1 Jan 21, 2021
@carlbuchmann carlbuchmann self-requested a review January 21, 2021 21:54
titom73
titom73 reviewed Jan 22, 2021
View reviewed changes
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/ethernet-interfaces.j2 Outdated
@@ -18,6 +18,13 @@ interface {{ ethernet_interface }}
{% if ethernet_interfaces[ethernet_interface].mtu is defined and ethernet_interfaces[ethernet_interface].mtu != 1500 %}
mtu {{ ethernet_interfaces[ethernet_interface].mtu }}
{% endif %}
{% if ethernet_interfaces[ethernet_interface].logging_event is defined and ethernet_interfaces[ethernet_interface].logging_event is not none %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature has been added for v2 with a different approach (#570)

  Ethernet6:
    logging:
      event:
        link_status: true

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tks. I had missed this PR #570. I changed it accordingly.

@titom73
Copy link
Contributor

titom73 commented Jan 22, 2021

Commits 66ee930 1678e78 should be backported to devel branch (cherry-pick is creates conflicts due to code update)

@titom73 titom73 changed the title Fr project 01 Enhance logging event, tacacs timeout and platform sand multicast replication features Jan 22, 2021
@titom73 titom73 self-requested a review January 25, 2021 07:34
titom73
titom73 approved these changes Jan 25, 2021
View reviewed changes
Copy link
Contributor

@titom73 titom73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good to me!

@titom73
Copy link
Contributor

titom73 commented Jan 26, 2021

cherry-picked to pre-release branch: https://github.com/titom73/ansible-avd/tree/release-v1.1.3-preparation

@titom73 titom73 mentioned this pull request Jan 26, 2021
Merged
@github-actions
Copy link

github-actions bot commented Feb 5, 2021

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the state: conflict PR with conflict label Feb 5, 2021
@titom73
Copy link
Contributor

titom73 commented Feb 11, 2021

Shipped in v1.1.3
Will be backport in v2.0.1 after code refactoring work

@titom73 titom73 closed this Feb 11, 2021
@titom73 titom73 mentioned this pull request Mar 24, 2021
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@titom73 titom73 titom73 approved these changes

@carlbuchmann carlbuchmann Awaiting requested review from carlbuchmann

Assignees

@aphillipps aphillipps

Labels
cherry-pick role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: conflict PR with conflict type: documentation Improvements or additions to documentation
Projects
None yet
Milestone
v1.1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@aphillipps @titom73 @carlbuchmann