Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add constraints on VRF in VXLAN IFL #83

Merged
merged 2 commits into from
Mar 2, 2020
Merged

Add constraints on VRF in VXLAN IFL #83

merged 2 commits into from
Mar 2, 2020

Conversation

titom73
Copy link
Contributor

@titom73 titom73 commented Feb 29, 2020

In case of a pure L2 environment, templates failed to generate VXLAN
interface because VRF was missing.

Fixes:

  • Add constraint on VRF for CLI config gen in VXLAN interface section.
  • Add constraint on VRF for documentation purpose in VXLAN section.

Fixes can be tested with following DC1_TENANTS_NETWORKS.yml file:

---
# DC1 Tenants Networks
# Documentation of Tenant specific information - Vlans/VRFs
tenants:
  Tenant_D:
    mac_vrf_vni_base: 40000
    l2vlans:
      411:
        name: 'Tenant_D_OP_Zone_1'
        tags: [opzone]
      412:
        name: 'Tenant_D_OP_Zone_2'
        tags: [opzone]

Resolves #78

@titom73
Add constraints on VRF in VXLAN ifl (#78)
b72a599 
In case of a pure L2 environment, templates failed to generate VXLAN
interface because VRF was missing.

Fixes:
- Add constraint on VRF for CLI config gen in VXLAN interface section.
- Add constraint on VRF for documentation purpose in VXLAN section.
@titom73 titom73 added the type: bug Something isn't working label Feb 29, 2020
@titom73 titom73 self-assigned this Feb 29, 2020
carlbuchmann
carlbuchmann approved these changes Mar 2, 2020
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann merged commit 1d411bf into releases/v1.0.x Mar 2, 2020
@carlbuchmann carlbuchmann deleted the issues/78-vlxna-with-only-l2vlans branch March 2, 2020 13:21
@carlbuchmann carlbuchmann mentioned this pull request Mar 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlbuchmann carlbuchmann carlbuchmann approved these changes

Assignees

@titom73 titom73

Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@titom73 @carlbuchmann