Don't run build-prep by default for create-srpm #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aajith-arista
force-pushed
the
aajith-no-buildprep
branch
2 times, most recently
from
54bbb71 to
1513962
Compare
mkisielewski-arista
previously approved these changes
Jan 15, 2025
aajith-arista
force-pushed
the
aajith-no-buildprep
branch
from
1513962 to
561ba29
Compare
manith-arista
approved these changes
Jan 16, 2025
Deprecated the "--skip-build-prep" option, making it a no-op, and build-prep is now skipped by default. The option "--do-build-prep" has been added for users wanting previous behavior. We cannot remove the option altogether because there're packages which make use of this flag via eextgen. The motivation is that users have been stumped by %prep failures because of missing dependencies in the their environment. It's not obvious that --skip-build-prep will workaround the problem.
aajith-arista
force-pushed
the
aajith-no-buildprep
branch
from
561ba29 to
816079b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecated the "--skip-build-prep" option, making it a no-op, and build-prep is now skipped by default. The option "--do-build-prep" has been added for users wanting previous behavior. We cannot remove --skip-check option altogether because there're packages which make use of this flag via eextgen.
The motivation is that users have been stumped by %prep failures because of missing dependencies in the their environment. It's not obvious that --skip-build-prep will workaround the problem.