CPU Architecture option #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sadi-a
force-pushed
the
sadi/architecture-option
branch
from
59d521c to
b103ef2
Compare
Sadi-a
force-pushed
the
sadi/architecture-option
branch
2 times, most recently
from
4f15b62 to
faf42c7
Compare
Sadi-a
force-pushed
the
sadi/architecture-option
branch
from
faf42c7 to
a63514d
Compare
|
the PR was in |
Typhoon on flatcar could previously only be run on x86_64 nodes. This commit changes this by adding a new variable per node which is cpu_architecture. This value is set by default on "x86_64". This variable is used for caching, selecting the architecture when installing flatcar, and grabbing the right files with the remote kernel and remote initrd This value can be set when defining a node at the same time as other attributes such a machine's domain, mac address or name.
Typhoon on fcos could previously only be run on x86_64 nodes. This commit changes this by adding a new variable per node which is cpu_architecture. This value is set by default on "x86_64" since flatcar uses the "x86_64/aarch64" notation for cpu architectures. This variable is used for caching, selecting the architecture when installing flatcar, and grabbing the right files with the remote kernel and remote initrd
Sadi-a
force-pushed
the
sadi/architecture-option
branch
from
a63514d to
d22c701
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typhoon on flatcar could previously only be run on x86_64 nodes.
This commit changes this by adding a new variable per node which is
cpu_architecture.
This value is set by default on "x86_64".
This variable is used for caching, selecting the architecture when
installing flatcar, and grabbing the right files with the remote
kernel and remote initrd.
This value can be set when defining a node at the same time
as other attributes such a machine's domain, mac address or
name.
This PR concerns both Flatcar Linux and Fedora CoreOS
Tested successfully on the test suite with x86_64 VMs.
I haven't tried with aarch64 VMs and mixed VMs (some aarch64, some x86_64) yet since I don't have KVM enabled for
qemu-system-aarch64(looks like I only have access to thetcgaccelerator there) and thus can't use terraform's libvirt since it requires KVM.