Changing the way the install_disk is set #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Formerly, the install_disk variable would affect all the machines configured with Typhoon. This meant that we could only set disks such as /dev/sda or /dev/nvme0n1 and that we could not use paths such as /dev/disk/by-* because those are associated to a single specific machine. This commit aims to change this by giving an install_disk attribute to controller and worker objects. This change affects both the FCOS and Flatcar Container Linux sides of things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Formerly, the install_disk variable would affect all the machines configured with Typhoon. This meant that we could only set disks such as /dev/sda or /dev/nvme0n1 and that we could not use paths such as /dev/disk/by-* because those are associated to a single specific machine.
This commit aims to change this by giving an install_disk attribute to controller and worker objects.
This change affects both the FCOS and Flatcar Container Linux sides of things.
This PR has been tested with the test-suite available on the
test-suitebranch.