Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]CPU temps are pushed to the right #14

Closed
thenoobtester opened this issue Sep 21, 2021 · 5 comments
Closed

[BUG]CPU temps are pushed to the right #14

thenoobtester opened this issue Sep 21, 2021 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@thenoobtester
Copy link

thenoobtester commented Sep 21, 2021

Describe the bug

When I choose to only display CPU temperatures in pane 1, they end up being pushed to the right and only the first digit is visible.

To Reproduce

Only show the CPU pane (no 1)

Expected behavior

CPU temps should remain visible.

Screenshots
btop-cpu-temp-ok

After a few seconds:

btop-cpu-temp-ko

Info (please complete the following information):

  • btop++ version: 1.0.1 and 1.0.2
  • Binary: static binary from release
  • Architecture: x86_64
  • Platform: Linux
  • (Linux) Kernel: 4.9.0-9-amd64
  • (OSX/FreeBSD) Os release version: Debian 9 (Stretch)
  • Terminal used: QTerminal
  • Font used: Hack Nerd Font

PS: It's doesn't do it on xterm but xterm doesn't show the dots.

@thenoobtester thenoobtester added the bug Something isn't working label Sep 21, 2021
@aristocratos
Copy link
Owner

@thenoobtester
Copy link
Author

Thank you, I set graphs to type: block and now it's ok :)

@correabuscar
Copy link
Contributor

correabuscar commented Nov 12, 2022

EDIT: Looks like whatever I posted below is unrelated to the very issue I posted these on, sorry for hijacking!

With

#* Default symbols to use for graph creation, "braille", "block" or "tty".
#* "braille" offers the highest resolution but might not be included in all fonts.
#* "block" has half the resolution of braille but uses more common characters.
#* "tty" uses only 3 different symbols but will work with most fonts and should work in a real TTY.
#* Note that "tty" only has half the horizontal resolution of the other two, so will show a shorter historical view.
graph_symbol = "braille"

in ~/.config/btop/btop.conf, and qterminal, things are misaligned, like so:
qterminal_noboxdrawinginfont

, and the following 3 solutions worked for me:

  1. set/enable qterminal Appearance->[x] Use box drawing characters contained in the font, looks like this after:
    qterminal_yesboxdrawinginfont

  2. (without doing 1. above), and as mentioned in the previous comment, do this: graph_symbol = "block", and it looks like:
    graph_symbol_block_screen-2022-11-12-10-13-22

  3. (without doing 1. above), do this graph_symbol = "tty", looks like:
    graph_symbol_tty_screen-2022-11-12-10-12-12

@aristocratos
Copy link
Owner

@correabuscar

set/enable qterminal Appearance->[x] Use box drawing characters contained in the font [...]

It seems like should be enabled by default?

I mean if the default for QTerminal is to not use the same font for symbols it seems weird that they haven't implemented some correction for difference in the widths of the font choosen and the font used for symbols.

@correabuscar
Copy link
Contributor

correabuscar commented Nov 12, 2022

@correabuscar

set/enable qterminal Appearance->[x] Use box drawing characters contained in the font [...]

It seems like should be enabled by default?

I mean if the default for QTerminal is to not use the same font for symbols it seems weird that they haven't implemented some correction for difference in the widths of the font choosen and the font used for symbols.

I (double)checked and it is not enabled by default(UseFontBoxDrawingChars=false, seen below), on Gentoo(but they aren't applying any patches for qterminal-1.2.0 and qtermwidget-1.2.0):
Here's ~/.config/qterminal.org/qterminal.ini newly generated:

[General]
AskOnExit=true
BoldIntense=true
BookmarksFile=/home/user/.config/qterminal.org/qterminal_bookmarks.xml
BookmarksVisible=true
Borderless=false
ChangeWindowIcon=true
ChangeWindowTitle=true
CloseTabOnMiddleClick=true
ConfirmMultilinePaste=false
DisableBracketedPasteMode=false
FixedTabWidth=true
FixedTabWidthValue=500
HandleHistory=
HideTabBarWithOneTab=false
HistoryLimited=true
HistoryLimitedTo=1000
KeyboardCursorShape=0
LastWindowMaximized=false
MenuVisible=true
MotionAfterPaste=2
NoMenubarAccel=true
OpenNewTabRightToActiveTab=false
PrefDialogSize=@Size(700 700)
SavePosOnExit=true
SaveSizeOnExit=true
ScrollbarPosition=2
ShowCloseTabButton=true
TabBarless=false
TabsPosition=0
Term=xterm-256color
TerminalBackgroundImage=
TerminalBackgroundMode=0
TerminalMargin=0
TerminalTransparency=0
TerminalsPreset=0
TrimPastedTrailingNewlines=false
UseBookmarks=false
UseCWD=false
UseFontBoxDrawingChars=false
colorScheme=Linux
emulation=default
enabledBidiSupport=true
fontFamily=Monospace
fontSize=12
guiStyle=
highlightCurrentTerminal=true
showTerminalSizeHint=true
version=1.2.0

[DropMode]
Height=45
KeepOpen=false
ShortCut=F12
ShowOnStart=true
Width=70

[MainWindow]
ApplicationTransparency=0
fixedSize=@Size(600 400)
pos=@Point(755 980)
size=@Size(600 420)
state=@ByteArray(\0\0\0\xff\0\0\0\0\xfd\0\0\0\x1\0\0\0\0\0\0\0\0\0\0\0\0\xfc\x2\0\0\0\x1\xfb\0\0\0&\0\x42\0o\0o\0k\0m\0\x61\0r\0k\0s\0\x44\0o\0\x63\0k\0W\0i\0\x64\0g\0\x65\0t\0\0\0\0\0\xff\xff\xff\xff\0\0\0w\0\xff\xff\xff\0\0\x2X\0\0\x1\x8d\0\0\0\x4\0\0\0\x4\0\0\0\b\0\0\0\b\xfc\0\0\0\0)

[Sessions]
size=0

[Shortcuts]
Add%20Tab=Ctrl+Shift+T
Bottom%20Subterminal=Alt+Down
Clear%20Active%20Terminal=Ctrl+Shift+X
Close%20Tab=Ctrl+Shift+W
Collapse%20Subterminal=
Copy%20Selection=Ctrl+Shift+C
Find=Ctrl+Shift+F
Fullscreen=F11
Handle%20history=
Hide%20Window%20Borders=
Left%20Subterminal=Alt+Left
Move%20Tab%20Left=Alt+Shift+Left|Ctrl+Shift+PgUp
Move%20Tab%20Right=Alt+Shift+Right|Ctrl+Shift+PgDown
New%20Window=Ctrl+Shift+N
Next%20Tab=Ctrl+PgDown
Next%20Tab%20in%20History=Ctrl+Shift+Tab
Paste%20Clipboard=Ctrl+Shift+V
Paste%20Selection=Shift+Ins
Preferences...=
Previous%20Tab=Ctrl+PgUp
Previous%20Tab%20in%20History=Ctrl+Tab
Quit=
Rename%20Session=Alt+Shift+S
Right%20Subterminal=Alt+Right
Show%20Tab%20Bar=
Split%20Terminal%20Horizontally=
Split%20Terminal%20Vertically=
Tab%201=
Tab%2010=
Tab%202=
Tab%203=
Tab%204=
Tab%205=
Tab%206=
Tab%207=
Tab%208=
Tab%209=
Toggle%20Bookmarks=Ctrl+Shift+B
Toggle%20Menu=Ctrl+Shift+M
Top%20Subterminal=Alt+Up
Zoom%20in=Ctrl++
Zoom%20out=Ctrl+-
Zoom%20reset=Ctrl+0

It is set to true by default in the lib aka qtermwidget (but they're overriding it in qterminal to be false by default).

I can't seem to find the reasoning for it in history:
lxqt/qtermwidget@64fef7a
lxqt/qterminal@6771a93

EDIT: I forgot to check the PRs: lxqt/qterminal#596
a similar align issue seems to be happening there but only when the setting is enabled. Which is the opposite of our situation. Then this is the reason for it being 'false'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants