Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macOS: fix crash if there exists a uid not associated with any user #831

Merged
merged 3 commits into from
Apr 28, 2024
Merged

macOS: fix crash if there exists a uid not associated with any user #831

merged 3 commits into from
Apr 28, 2024

Conversation

thecoder-001
Copy link
Contributor

@thecoder-001 thecoder-001 commented Apr 27, 2024 •
edited
Loading

Fixes crash if there exists a uid not associated with any user.
Fixes #830

Equivalent behaviour to linux:

MacOS Linux
Screenshot 2024-04-28 at 3 52 33 AM Screenshot 2024-04-28 at 3 49 47 AM

@thecoder-001
fix: crash on osx proc box
08f90fb 
Signed-off-by: thecoder-001 <ayush06feb@gmail.com>
@thecoder-001
osx: show uid instead of 'unknown' if no user exists with the same
9a37395 
Signed-off-by: thecoder-001 <ayush06feb@gmail.com>
@thecoder-001 thecoder-001 changed the title macOS: fix crash when proc box is displayed macOS: fix crash if there exists a uid not associated with any user Apr 27, 2024
aristocratos
aristocratos requested changes Apr 28, 2024
View reviewed changes
Copy link
Owner

@aristocratos aristocratos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

But the warning to log should be removed, the fact that the UID is displayed instead of the name should make it apparent that we failed to get a username.

@thecoder-001
Remove logging for uid without username
5ba45f7 
Signed-off-by: thecoder-001 <ayush06feb@gmail.com>
@thecoder-001
Copy link
Contributor Author

Removed the logging part.

aristocratos
aristocratos approved these changes Apr 28, 2024
View reviewed changes
Copy link
Owner

@aristocratos aristocratos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!

@aristocratos aristocratos merged commit 0e07deb into aristocratos:main Apr 28, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aristocratos aristocratos aristocratos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] macOS arm64: Crash (SIGSEGV) on launch
2 participants
@thecoder-001 @aristocratos