-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rotate options in javascript #169
base: master
Are you sure you want to change the base?
Conversation
TODO : reactivate gulp-header
I had to disable the header banner in gulp because it crash. |
Great work @bastienmoulia ! I'll take a look other this commit in more detail over next days. @ariutta can you please confirm that that's the right version of BSD license? The complete list is here. Thanks! |
Had the same header issue and made a fix in #178 . I don't know exactly how this will merge. |
@bumbu since this PR is almost 1 year old, should we keep it open? |
If this fonction is needed i can make a new PR with an updated version. |
@bastienmoulia and @bumbu, I apologize for the delay here. I'm sorry that I don't really have the bandwidth to properly review pull requests for new features right now. @Yimiprod, I invited you to be a collaborator. You and any of the other collaborators can feel free to manage issues and pull requests, using your best judgment. @aleofreddi, you originally specified a BSD license. Is BSD-2-Clause correct? |
Hi, As a big time user of this extension in angular is there any view on when this will be merged? Can I merge these files locally myself? Br, Tom |
Hi i finally got my fork running by upgrading to gulp v 4 (node 12 +) I tested this pull request and it works! EDIT: Since this pull request is so old I will try based on this one to make a new one with the rotate option. (which do not have conflicts) |
var that = this | ||
, s = 'matrix(' + matrix.a + ',' + matrix.b + ',' + matrix.c + ',' + matrix.d + ',' + matrix.e + ',' + matrix.f + ')'; | ||
|
||
if (rotate.angle !== 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would keep rotation optional:
if(rotate && typeof rotate.angle === "number" && rotate.angle !== 0)
https://docs.npmjs.com/files/package.json#license