onLoadFinished not triggered #10265

gregwebs · 2011-10-18T04:03:20Z

version: 1.3.0

Note, I am using the ghostbusters library to use phantom.js, but I don't think that should effect anything.

reproduce:

Hook up to the callbacks

@page.onLoadStarted = () -> console.log "LOAD STARTED"
@page.onLoadFinished = (status) -> console.log("LOAD FINISHED: status " + status)

Observe that only LOAD STARTED is seen.

expected:

LOAD FINISHED should have also been seen.

Disclaimer:
This issue was migrated on 2013-03-15 from the project's former issue tracker on Google Code, Issue #265.
🌟 9 people had starred this issue at the time of migration.

ariya · 2011-10-18T04:43:11Z

ariya.hi...@gmail.com commented:

Which URL shows this problem?

gregwebs · 2011-10-18T04:51:11Z

g...@gregweber.info commented:

I don't ever see that the load is finished. I am running a test that opens a page, fills out a form and clicks a submit. that submit opens a new page. I see 2 starts in the console but no finishes.

ariya · 2011-10-19T13:01:17Z

ariya.hi...@gmail.com commented:

It would be hard to believe that onLoadFinished is not triggered, a lot of examples rely on this behavior.

If there is a new page opened, then it may be that finish callback needs to be implemented for the page.

ariya · 2011-11-28T21:28:11Z

sylvinus@gmail.com commented:

I'm also not seeing any onLoadFinished() callbacks firing, even on very simple hello world pages. (mac os x 10.6)

ariya · 2011-11-28T21:34:00Z

ariya.hi...@gmail.com commented:

Here's a super simple script to try. If running PhantomJS with this script does not give the finish message, something is seriously wrong. Otherwise, please post the test case which demonstrates "onLoadFinished not firing" situation.

var page = new WebPage();

page.onLoadStarted = function () {
console.log('Start loading...');
};

page.onLoadFinished = function (status) {
console.log('Loading finished.');
phantom.exit();
};

page.open('http://example.com');

ariya · 2011-12-20T05:12:58Z

ariya.hi...@gmail.com commented:

Ping.

scophotog · 2012-01-19T23:44:05Z

scott....@gmail.com commented:

Not sure if this is related. It seems onLoadFinished doesn't actually wait for the page to completely finish loading. I have a script which loads multiple pages and then runs a check on each. It loads the URLs from a JSON file:

var objs = JSON.parse(data)

for (i = 0; i < objs.length; i++) {
(function(obj) {
var page = new WebPage();
page.open(obj.url);
page.onLoadFinished = function() {
var c = page.evaluate(function() {
//return something
});
console.log('Output ' + c);
}(objs[i]);
}

With 1 record, it loads and works. With 3 records, I can see it trying to output to the console but the page isn't completely loaded, then when the pages finally load I'll get the output from within onLoadFinished. To see the effect use sites that are fairly content heavy.

ariya · 2012-03-14T10:23:12Z

ariya.hi...@gmail.com commented:

I'm not sure I understand the 3 records problem. Do you see 3 'Output...' at once? Are they all wrong?

Another thing to try is to insert another console.log before calling page.evaluate, just to show the loading status.

magopian · 2012-03-28T23:39:29Z

mathieu....@gmail.com commented:

Running the "simple" script above did indeed give me a "loading finished". However this very small variation didn't:

var page = new WebPage();

page.onLoadStarted = function () {
console.log('Start loading...');
};

page.onLoadFinished = function (status) {
console.log('Loading finished.');
phantom.exit();
};

page.open('http://example.com', function(status) {
console.log('loading');
});

ariya · 2012-06-22T22:26:33Z

t...@arachnys.com commented:

WebPage#open replaces page.onLoadFinished with the callback you pass it - it's totally non-obvious, and I only realised this by looking at the Casper.js source, and then the phantom source.

See https://github.com/ariya/phantomjs/blob/master/src/modules/webpage.js#L141 . I imagine you could verify if with

page.onLoadFinished = function (status) {
console.log('Loading finished.');
phantom.exit();
};

var handler;
page.open('http://example.com', handler = function(status) {
console.log('loading');
});
console.log("onLoadFinished stomped:",handler === page.onLoadFinished);

ariya · 2012-09-04T07:10:09Z

ariya.hi...@gmail.com commented:

Second ping.

detro · 2012-09-26T06:58:12Z

detroniz...@gmail.com commented:

I can confirm this issue is real.

Comment #10 explains the issue well.

I'm working on a fix of this.

Metadata Updates

Label(s) added:
- webdriver
Milestone updated: FutureRelease (was: ---)
Owner updated: detroniz...@gmail.com

detro · 2012-09-26T07:01:01Z

detroniz...@gmail.com commented:

Issue 504 has been merged into this issue.

detro · 2012-09-26T07:03:13Z

detroniz...@gmail.com commented:

Issue 376 has been merged into this issue.

ariya · 2012-09-26T07:13:12Z

ariya.hi...@gmail.com commented:

Comment #10 described the documented behavior. I'm not sure it explains the issue.

Here is a test script:
var page = require('webpage').create();

page.onLoadStarted = function (status) {
  console.log('Start');
};

page.onLoadFinished = function (status) {
  console.log('Finish 1');
  phantom.exit();
};

page.open('http://example.com', function() {
  console.log('Finish 2');
  phantom.exit();
});
The output is:

Start
Finish 2

which is pretty much as expected.

I wonder which situation/URL will never give onLoadFinished at all.

detro · 2012-09-26T07:18:03Z

detroniz...@gmail.com commented:

The behaviour should be a double trigger: 1 for the callback registered for "onLoadFinished" - the other for the page.open callback provided.

The code above shows that a callback set with "page.open" override the onLoadFinished previously set.

While the reason is obvious (we use that signal to trigger the open callback), the behaviour that I would expect (and I think others expect too) is that we fire both: the registered handler AND the callback provided by open.

I have a solution to this btw.
Just need some time to polish stuff and catch some sleep.

JamesMGreene · 2012-09-26T07:35:07Z

james.m....@gmail.com commented:

I also have a solution to this, though mine is more of a complete paradigm shift (I redesigned the event API). Will try to commit my ideas soon to share, maybe tonight even.
~~James

ariya · 2012-09-26T07:46:43Z

ariya.hi...@gmail.com commented:

If we want to change the behavior, better discuss it in the mailing-list and open a new issue.

Reading through the origina post of this bug, it has nothing to do with override of onLoadFinished.

detro · 2012-09-26T15:10:31Z

detroniz...@gmail.com commented:

@ariya: to me sounds like this story is ALL about onLoadFinished being overridden.
Infact, Greg above said:
"LOAD FINISHED should have also been seen."
I understand that maybe what you are saying is that "the expectations were wrong - that's not the behaviour", but I actually think it's an "expectable" behaviour that we silently override.

Will open a new issue and spin up a mailing list discussion.
This story, in the mean time, I'll mark as "WontFix".

Metadata Updates

Status updated: WontFix

ariya · 2012-09-26T21:04:42Z

ariya.hi...@gmail.com commented:

"LOAD FINISHED should have also been seen."

I would have agreed to that if there was ever a confirmation that page.open is being called with an extra handler, unlike my example in comment #5.

Newly spawn issue is issue 801: onLoadFinished should trigger even if a callback is provided for "page.open()".

detro · 2012-09-26T21:07:29Z

detroniz...@gmail.com commented:

Sorry. Can you rephrase? I'm not sure I understand what you mean here.

ariya · 2012-09-26T21:18:24Z

ariya.hi...@gmail.com commented:

The OP needs to post the entire script so that we can confirm whether it is (1) onLoadFinished + open(url, handler) or just (2) onLoadFinished + open(url).

detro · 2012-09-26T21:21:55Z

detroniz...@gmail.com commented:

From comment #2 I understand that he operates on the page after has loaded.
He doesn't know (and that's my point about confusing API behaviour) that the very handler he uses to operate on the page, has disabled his "onLoadFinished".

Another example of this is at the Issue #801 that I opened.

alonmove · 2013-06-24T13:43:42Z

happens to me as well. onLoadFinished callback not fired.

thomasmodeneis · 2014-02-21T08:38:07Z

what was the resolution for this ???

anusha121212 · 2014-10-14T12:32:26Z

Hi am trying to call ajax request using Phantom js and selenium java bindings. Please find the requirement and issue am facing below:
Requirement:
Need to drag and drop widget
while drag and dropping ajax call is made-----here page keeps on loading it doesn't stop. please help me to solve dis. on this particular scenario all test cases are based.

BES1st · 2016-09-12T14:50:01Z

Hello @ariya ,

Can you try the code with this url: http://vilagutazo.blog.hu ?
Lot of Finish1 and lot of Finish 2 in the console log.
Million thanks!

Gabor

BES1st · 2016-09-13T07:49:51Z

and I have an little problem:
Crash Annotation GraphicsCriticalError: |[0][GFX1-]: Too many dropped/corrupted frames, disabling DXVA (t=14931.3)[GFX1-]: Too many dropped/corrupted frames, disabling DXVA
What's this? Can you help me?

Thanks!

Gabor

iyyappan13391 · 2016-12-15T12:19:39Z

Some guys made duplicate and closed and merge..etc,What is the solution for this???

@phantom developer's what doing???

page.onLoadFinished = function (status) {
console.log('Loading finished.');
phantom.exit();
};

drcrack · 2017-11-24T12:33:50Z

still not working

detro closed this as completed Sep 26, 2012

This was referenced Mar 15, 2013

onLoadFinished not running when a callback is provided #10376

Closed

page.open callback called multiple times if page creates iframes dynamically #10504

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

onLoadFinished not triggered #10265

onLoadFinished not triggered #10265

gregwebs commented Oct 18, 2011

ariya commented Oct 18, 2011

gregwebs commented Oct 18, 2011

ariya commented Oct 19, 2011

ariya commented Nov 28, 2011

ariya commented Nov 28, 2011

ariya commented Dec 20, 2011

scophotog commented Jan 19, 2012

ariya commented Mar 14, 2012

magopian commented Mar 28, 2012

ariya commented Jun 22, 2012

ariya commented Sep 4, 2012

detro commented Sep 26, 2012

detro commented Sep 26, 2012

detro commented Sep 26, 2012

ariya commented Sep 26, 2012

detro commented Sep 26, 2012

JamesMGreene commented Sep 26, 2012

ariya commented Sep 26, 2012

detro commented Sep 26, 2012

ariya commented Sep 26, 2012

detro commented Sep 26, 2012

ariya commented Sep 26, 2012

detro commented Sep 26, 2012

alonmove commented Jun 24, 2013

thomasmodeneis commented Feb 21, 2014

anusha121212 commented Oct 14, 2014

BES1st commented Sep 12, 2016 •

edited

Loading

BES1st commented Sep 13, 2016

iyyappan13391 commented Dec 15, 2016

drcrack commented Nov 24, 2017

onLoadFinished not triggered #10265

onLoadFinished not triggered #10265

Comments

gregwebs commented Oct 18, 2011

ariya commented Oct 18, 2011

gregwebs commented Oct 18, 2011

ariya commented Oct 19, 2011

ariya commented Nov 28, 2011

ariya commented Nov 28, 2011

ariya commented Dec 20, 2011

scophotog commented Jan 19, 2012

ariya commented Mar 14, 2012

magopian commented Mar 28, 2012

ariya commented Jun 22, 2012

ariya commented Sep 4, 2012

detro commented Sep 26, 2012

detro commented Sep 26, 2012

detro commented Sep 26, 2012

ariya commented Sep 26, 2012

detro commented Sep 26, 2012

JamesMGreene commented Sep 26, 2012

ariya commented Sep 26, 2012

detro commented Sep 26, 2012

ariya commented Sep 26, 2012

detro commented Sep 26, 2012

ariya commented Sep 26, 2012

detro commented Sep 26, 2012

alonmove commented Jun 24, 2013

thomasmodeneis commented Feb 21, 2014

anusha121212 commented Oct 14, 2014

BES1st commented Sep 12, 2016 • edited Loading

BES1st commented Sep 13, 2016

iyyappan13391 commented Dec 15, 2016

drcrack commented Nov 24, 2017

BES1st commented Sep 12, 2016 •

edited

Loading