This repository was archived by the owner on May 30, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Added "phantom.simulateMouseClick" and other minors for debugging. #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 'phantom.simulateMouseClick' accepts a 'selector' and clicks on every element that matches the selector * Added a couple of 'qDebug()' to help debugging PhantomJS
I prefer to get this functionality (or something similar) after issue 41 is solved. Let's keep this open. |
OK, but what exactly is the connection there? |
It falls under the same ideal restriction: "any scripts running in the page should not be able to access certain phantom functions". Giving it a second thought, I think this one should be safe since it's just a convenient function. Also we should be able to group features like this once we have module support (issue 32). |
I see. Still, while you (we?) find a solution to the sandboxing problem, this feat. might come handy. |
ariya
pushed a commit
that referenced
this pull request
Oct 5, 2011
lfranchi
pushed a commit
to lfranchi/phantomjs
that referenced
this pull request
Oct 25, 2011
This was referenced Mar 15, 2013
This was referenced Mar 15, 2013
Closed
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Ariya,
this adds support for "phantom.simulateMouseClick": it's implemented using the code that was there for "uploading input file". I also sorteed that out, putting everything into a simple macro.
It uses a query selector to do the trick, so it can click multiple things, if the selector matches more than one dom element.
Hope you find it useful.
Ivan