Skip to content
This repository was archived by the owner on May 30, 2023. It is now read-only.

API & Documentation site (2) #11748

Closed
wants to merge 10 commits into from
Closed

API & Documentation site (2) #11748

wants to merge 10 commits into from

Conversation

JamieMason
Copy link
Collaborator

A resubmission of Pull Request #11617. I ran into some rebase/merge problems which resulted in old commits displaying on the issue tracking page — apologies for this.

Hey,
As discussed in the mailing list, this pull request aims to relocate the API & Documentation currently in the GitHub Wiki to be accessible from phantomjs.org, with users encouraged to contribute improvements to each page.

Details on how to maintain the gh-pages branch can be found in it's CONTRIBUTING.md file.

Please let me know of anything else I can do to help.

Thanks,

Jamie, @fold_left

@ariya
Copy link
Owner

ariya commented Nov 24, 2013

Looks really good! I'm about to merge it with minor tweaks on the commit messages (since I'd really like it to link to issue #10627, which is strongly related and relevant to this work).

Thank you very much!

@ariya
Copy link
Owner

ariya commented Nov 24, 2013

Landed. Thanks for this wonderful contribution 👍

@ariya ariya closed this Nov 24, 2013
@ariya
Copy link
Owner

ariya commented Nov 24, 2013

Hmm, seems that GitHub can't build that page, http://phantomjs.org/ gives 404. @JamieMason any ideas?

@ariya ariya reopened this Nov 24, 2013
@ariya
Copy link
Owner

ariya commented Nov 24, 2013

Apparently it was just a missing CNAME file. Fixed in commit 59bad6e.

@ariya ariya closed this Nov 24, 2013
@JamesMGreene
Copy link
Collaborator

We need to merge some changes that have been made to the Wiki after this set was created. We also need to disable the Wiki when we're done with it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants