This repository was archived by the owner on May 30, 2023. It is now read-only.
Small improvements in the way the "usage message" is printed. #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 'phantom.simulateMouseClick' accepts a 'selector' and clicks on every element that matches the selector * Added a couple of 'qDebug()' to help debugging PhantomJS
* "phantom.loadJs()" loads a JS file and executes it's content within the current Document Context. It's synchronous. * "phantom.includeJs()" adds a <script> tag include. It's asynchronous and accepts as second parameter a "callback", fired when the js file has been loaded. * Some more qDebug() calls * qDebug() output disabled by default in the .pro file NOTE: I'm adding qDebug() calls to make development of phantomjs easier and "debuggable"
Conflicts: src/phantomjs.cpp
…rce". Also: * I added a couple of "qFatal" where it makes sense. * Usage now mentions the fact that the input files that finish by ".coffee" are also acceptable
|
A common practice to avoid this kind of confusion is to create a separate branch, from which the pull request is made. Then it should be easy to isolate/control which commit(s) should be in that branch. |
|
About qFatal: I added that there because if the loading of that resource file, something really wrong must be going on. Hence, the use of qFatal. Anyway, I will sort out the pull request again. Bear with me. PS I assume that you still don't want to pull in "simulateMouseClick" and "loadJs" :) |
|
I already cherry picked the latest commit. |
|
Ops. Didn't see that. Have a good day than :) |
This was referenced Mar 15, 2013
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That's at least the idea.
Somehow though I don't seem to be able to just pick the last commit: it must be the fact that I just merged your master tree into mine, creating sort of a dependency tree that comes with my latest commit.
The stuff in those previous commits is already in other pull requests: do as it suits you.
I'm currently on hold for doing the "small class refactoring" that I mentioned before: but the more the code grows, the more I feel like classes should be separated into headers and sources.
Ivan