This repository has been archived by the owner on May 30, 2023. It is now read-only.
Major refactoring #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 'phantom.simulateMouseClick' accepts a 'selector' and clicks on every element that matches the selector * Added a couple of 'qDebug()' to help debugging PhantomJS
* "phantom.loadJs()" loads a JS file and executes it's content within the current Document Context. It's synchronous. * "phantom.includeJs()" adds a <script> tag include. It's asynchronous and accepts as second parameter a "callback", fired when the js file has been loaded. * Some more qDebug() calls * qDebug() output disabled by default in the .pro file NOTE: I'm adding qDebug() calls to make development of phantomjs easier and "debuggable"
Conflicts: src/phantomjs.cpp
…rce". Also: * I added a couple of "qFatal" where it makes sense. * Usage now mentions the fact that the input files that finish by ".coffee" are also acceptable
This doesn't add ANY new feature: it's aimed only at separating code into more manageable pieces. Maybe it's not perfect yet, but it's a start.
The new Network Access Manager currently is designed to do just logging: - logs HTTP Method type - logs HTTP Destination URL The new 'browsermode': It's in "/examples" and make PhantomJS do just a call to "open(url)". It has a companion shell script to help with the task. Also, improvement for Message Handler: messages are now prefixed with ISO Datetime.
I always forget that the Pre-Compiler passes only once.
|
Looks good, thanks! I have to amend some parts due to various reasons (check the upstream master). |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch addresses different issues, but it's mainly focused on Issue #85.
Also, It introduces a new "Network Access Manager": that goes against Issue #2 and Issue #45.
In here I also (by mistake) added a new example, called 'browsermode.js': this script should help to use PhantomJS in a more 'browser-ish' mode, but it's not there yet. Possibly because of stuff like Issue #67 and Issue #26.
I do have to apologize though: this should have been splitted in at least 3 different branches.
Let me know what do you think.