Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Micro from700 reduced egamma #24

Open
wants to merge 8 commits into
base: micro-from700-andrea
Choose a base branch
from

Conversation

bendavid
Copy link

Implement a comprehensive slimming and relinking of electron and photon collections through a dedicated producer. This removes the duplication of embedded cluster information between electrons and photons.

Reduced conversion collections (with loose matching) are also produced.

Stored information is not exactly the same as before (can be tweaked further).

Current selection is
keepPhotons = cms.string("pt > 14 && hadTowOverEm()<0.15"),
relinkPhotons = cms.string("(r9()>0.8 || chargedHadronIso()<20 || chargedHadronIso()<0.3*pt())"),
keepGsfElectrons = cms.string(""),
relinkGsfElectrons = cms.string("pt>5"),

The "keep" selections control which objects are stored. The "relink" selections control for which objects the dependent clusters/rechits/conversions are to be stored in the associated reduced collections and refs relinked.

Contrary to before, the SuperCluster and seed cluster are only included if the "relink" selection is passed. (The last configuration for embedding was keeping these for all.)

There is additional information being stored through the conversions, and also the preshower clusters/rechits which were not included previously in the embedding. (Can be discussed if this is really needed).

Net effect on event size is a minor (1.5% total) reduction for ttbar and essentially no change for jetHT data. (Attached are edmEventSize dumps)

(I see that it won't merge automatically due to the last change in the configs, will rebase it tomorrow)

@bendavid
Copy link
Author

ttbar MC before:
patPackedCandidates_packedPFCandidates__PAT. 63405.6 13344.9
patPackedGenParticles_packedGenParticles__PAT. 27189.6 3234.76
patElectrons_slimmedElectrons__PAT. 11656.4 3090.62
patMuons_slimmedMuons__PAT. 5769.3 2012.69
patTriggerObjectStandAlones_selectedPatTrigger__PAT. 29578.2 1918.04
patPhotons_slimmedPhotons__PAT. 6686.96 1911.84
patJets_slimmedJets__PAT. 15414 1360.05
recoGenParticles_prunedGenParticles__PAT. 4643.14 966.042
recoVertexs_offlineSlimmedPrimaryVertices__PAT. 1193.16 670.576
patTaus_slimmedTaus__PAT. 5030.29 587.562
patMETs_slimmedMETs__PAT. 1253.24 437.549
patJets_slimmedJetsCA8__PAT. 2460.03 297.653
recoGenJets_slimmedGenJets__PAT. 774.215 261.954
recoVertexCompositePtrCandidates_slimmedSecondaryVertices__PAT. 602.841 240.454
patPackedCandidates_lostTracks__PAT. 230.746 89.594
L1GlobalTriggerReadoutRecord_gtDigis__HLT. 1953.28 80.1779
GenEventInfoProduct_generator__SIM. 192.798 73.4328
edmTriggerResults_TriggerResults__HLT. 989.368 71.4089
l1extraL1MuonParticles_l1extraParticles__HLT. 208.998 45.6188
l1extraL1EtMissParticles_l1extraParticles_MET_HLT. 180.071 29.421
l1extraL1EtMissParticles_l1extraParticles_MHT_HLT. 180.071 28.3317
l1extraL1JetParticles_l1extraParticles_Central_HLT. 251.51 27.6656
l1extraL1EmParticles_l1extraParticles_NonIsolated_HLT. 265.45 27.2857
l1extraL1EmParticles_l1extraParticles_Isolated_HLT. 297.114 25.318
l1extraL1JetParticles_l1extraParticles_Tau_HLT. 183.862 23.0464
l1extraL1JetParticles_l1extraParticles_Forward_HLT. 140.342 22.4734
PileupSummaryInfos_addPileupInfo__HLT. 456.393 21.5249
l1extraL1HFRingss_l1extraParticles__HLT. 103.042 9.07422
patPackedTriggerPrescales_patTrigger__PAT. 1856.49 8.72778
recoBeamSpot_offlineBeamSpot__RECO. 325.819 8.08944
double_fixedGridRhoFastjetAllCalo__RECO. 9.51656 7.82878
double_fixedGridRhoFastjetCentralChargedPileUp__RECO. 9.56567 7.82189
double_fixedGridRhoFastjetCentralNeutral__RECO. 9.543 7.79922
double_fixedGridRhoFastjetCentralCalo__RECO. 9.53167 7.78022
double_fixedGridRhoFastjetAll__RECO. 9.50144 7.77989
EventAuxiliary 129.259 4.896
double_fixedGridRhoAll__RECO. 9.475 4.29433
edmTriggerResults_TriggerResults__PAT. 100.601 2.62956
EventSelections 90.2367 2.024
doubles_ak5TrackJets_rhos_RECO. 15.4963 1.63878
doubles_ak5PFJetsCHS_rhos_RECO. 15.4963 1.63878
doubles_ak5CaloJets_rhos_RECO. 15.4926 1.63056
doubles_ak5PFJets_rhos_RECO. 15.485 1.623
doubles_ak5GenJets_rhos_SIM. 15.485 1.623
BranchListIndexes 22.1904 1.31911
EventProductProvenance 16.1993 1.21778
double_ak5TrackJets_rho_RECO. 9.475 0.699667
double_ak5PFJetsCHS_rho_RECO. 9.475 0.699667
double_ak5CaloJets_rho_RECO. 9.47122 0.695889
double_ak5PFJets_rho_RECO. 9.46367 0.688333
double_ak5GenJets_rho_SIM. 9.46367 0.688333

after:
Branch Name | Average Uncompressed Size (Bytes/Event) | Average Compressed Size (Bytes/Event)
patPackedCandidates_packedPFCandidates__PAT. 63408.3 13297.1
patPackedGenParticles_packedGenParticles__PAT. 27190 3235.63
patMuons_slimmedMuons__PAT. 5750.62 1982.61
patTriggerObjectStandAlones_selectedPatTrigger__PAT. 29578.6 1921.52
patElectrons_slimmedElectrons__PAT. 5033.17 1399.09
patJets_slimmedJets__PAT. 15413 1359.43
recoGenParticles_prunedGenParticles__PAT. 4642.89 964.976
EcalRecHitsSorted_reducedEgamma_reducedEBRecHits_PAT. 1727.6 706.684
recoVertexs_offlineSlimmedPrimaryVertices__PAT. 1192.98 669.48
patPhotons_slimmedPhotons__PAT. 1799.96 593.799
patTaus_slimmedTaus__PAT. 5027.49 582.414
recoConversions_reducedEgamma_reducedConversions_PAT. 2880.32 512.988
recoCaloClusters_reducedEgamma_reducedEBEEClusters_PAT. 1273.96 457.381
patMETs_slimmedMETs__PAT. 1252.49 435.643
recoSuperClusters_reducedEgamma_reducedSuperClusters_PAT. 1371.87 380.76
patJets_slimmedJetsCA8__PAT. 2455.79 288.093
recoGenJets_slimmedGenJets__PAT. 773.894 262.278
recoVertexCompositePtrCandidates_slimmedSecondaryVertices__PAT. 602.536 239.65
recoCaloClusters_reducedEgamma_reducedESClusters_PAT. 968.314 228.38
EcalRecHitsSorted_reducedEgamma_reducedEERecHits_PAT. 496.748 223.522
EcalRecHitsSorted_reducedEgamma_reducedESRecHits_PAT. 415.548 127.606
patPackedCandidates_lostTracks__PAT. 229.826 87.535
L1GlobalTriggerReadoutRecord_gtDigis__HLT. 1953.28 80.2001
GenEventInfoProduct_generator__SIM. 192.657 73.1322
edmTriggerResults_TriggerResults__HLT. 989.353 71.1846
l1extraL1MuonParticles_l1extraParticles__HLT. 208.584 44.2617
recoConversions_reducedEgamma_reducedSingleLegConversions_PAT. 285.893 42.2982
l1extraL1EtMissParticles_l1extraParticles_MET_HLT. 179.807 28.6429
l1extraL1EtMissParticles_l1extraParticles_MHT_HLT. 179.807 27.5363
l1extraL1JetParticles_l1extraParticles_Central_HLT. 251.243 27.0087
l1extraL1EmParticles_l1extraParticles_NonIsolated_HLT. 265.179 26.7407
l1extraL1EmParticles_l1extraParticles_Isolated_HLT. 296.848 24.6473
l1extraL1JetParticles_l1extraParticles_Tau_HLT. 183.602 22.3931
recoPhotonCores_reducedEgamma_reducedGedPhotonCores_PAT. 150.338 21.3686
PileupSummaryInfos_addPileupInfo__HLT. 456.194 21.0507
l1extraL1JetParticles_l1extraParticles_Forward_HLT. 139.431 20.896
recoGsfElectronCores_reducedEgamma_reducedGedGsfElectronCores_PAT. 113.388 18.3732
l1extraL1HFRingss_l1extraParticles__HLT. 102.96 8.90011
patPackedTriggerPrescales_patTrigger__PAT. 1856.3 8.42133
double_fixedGridRhoFastjetCentralChargedPileUp__RECO. 9.533 7.76944
double_fixedGridRhoFastjetCentralCalo__RECO. 9.501 7.74944
double_fixedGridRhoFastjetCentralNeutral__RECO. 9.51167 7.74811
double_fixedGridRhoFastjetAllCalo__RECO. 9.48678 7.745
double_fixedGridRhoFastjetAll__RECO. 9.47256 7.73078
recoBeamSpot_offlineBeamSpot__RECO. 325.571 7.69733
EventAuxiliary 129.247 4.836
double_fixedGridRhoAll__RECO. 9.44767 4.24278
edmTriggerResults_TriggerResults__PAT. 100.571 2.55911
EventSelections 90.2242 1.98922
doubles_ak5TrackJets_rhos_RECO. 15.4677 1.58989
doubles_ak5PFJetsCHS_rhos_RECO. 15.4677 1.58989
doubles_ak5CaloJets_rhos_RECO. 15.4641 1.58189
doubles_ak5PFJets_rhos_RECO. 15.457 1.57478
doubles_ak5GenJets_rhos_SIM. 15.457 1.57478
BranchListIndexes 22.1778 1.29078
EventProductProvenance 16.1861 1.19022
double_ak5TrackJets_rho_RECO. 9.44767 0.658333
double_ak5PFJetsCHS_rho_RECO. 9.44767 0.658333
double_ak5CaloJets_rho_RECO. 9.44411 0.654778
double_ak5PFJets_rho_RECO. 9.437 0.647667
double_ak5GenJets_rho_SIM. 9.437 0.647667

@bendavid
Copy link
Author

JetHT data before:
Branch Name | Average Uncompressed Size (Bytes/Event) | Average Compressed Size (Bytes/Event)
patPackedCandidates_packedPFCandidates__PAT. 52497.1 10838
patElectrons_slimmedElectrons__PAT. 7697.17 2128.47
patPhotons_slimmedPhotons__PAT. 6202.16 1891.65
patMuons_slimmedMuons__PAT. 4036.2 1370.68
patTriggerObjectStandAlones_selectedPatTrigger__PAT. 14910.6 1212.26
patJets_slimmedJets__PAT. 11662.2 1103.18
patTaus_slimmedTaus__PAT. 4829.94 619.609
recoVertexs_offlineSlimmedPrimaryVertices__PAT. 945.59 537.356
patJets_slimmedJetsCA8__PAT. 3520.48 376.566
patMETs_slimmedMETs__PAT. 1050.52 361.818
recoVertexCompositePtrCandidates_slimmedSecondaryVertices__PAT. 430.899 170.596
patPackedCandidates_lostTracks__PAT. 183.553 64.105
edmTriggerResults_TriggerResults__HLT. 981.85 59.0357
patPackedTriggerPrescales_patTrigger__PAT. 1842.9 35.297
EventAuxiliary 129.485 24.6294
recoBeamSpot_offlineBeamSpot__reRECO. 329.157 11.7903
double_fixedGridRhoFastjetAllCalo__reRECO. 9.75839 7.98882
double_fixedGridRhoFastjetCentralChargedPileUp__reRECO. 9.8222 7.98064
double_fixedGridRhoFastjetCentralNeutral__reRECO. 9.79275 7.95119
double_fixedGridRhoFastjetCentralCalo__reRECO. 9.77802 7.93864
double_fixedGridRhoFastjetAll__reRECO. 9.73875 7.92119
double_fixedGridRhoAll__reRECO. 9.70439 4.45296
edmTriggerResults_TriggerResults__PAT. 101.028 3.44232
EventSelections 107.459 2.6354
doubles_ak5PFJetsCHS_rhos_reRECO. 15.7614 1.85956
doubles_ak5TrackJets_rhos_reRECO. 15.7614 1.85956
doubles_ak5CaloJets_rhos_reRECO. 15.7562 1.8522
doubles_ak5PFJets_rhos_reRECO. 15.7458 1.84292
BranchListIndexes 22.2716 1.32615
EventProductProvenance 16.2569 1.14971
double_ak5PFJetsCHS_rho_reRECO. 9.70439 0.864194
double_ak5TrackJets_rho_reRECO. 9.70439 0.864194
double_ak5CaloJets_rho_reRECO. 9.69948 0.859286
double_ak5PFJets_rho_reRECO. 9.68966 0.849468

after:
Branch Name | Average Uncompressed Size (Bytes/Event) | Average Compressed Size (Bytes/Event)
patPackedCandidates_packedPFCandidates__PAT. 52499.8 10853.6
patMuons_slimmedMuons__PAT. 4032.15 1364.97
patTriggerObjectStandAlones_selectedPatTrigger__PAT. 14911.7 1218.93
patJets_slimmedJets__PAT. 11662.5 1105.39
patElectrons_slimmedElectrons__PAT. 3440.52 923.271
EcalRecHitsSorted_reducedEgamma_reducedEBRecHits_PAT. 1435.11 707.843
patTaus_slimmedTaus__PAT. 4830.05 620.49
recoVertexs_offlineSlimmedPrimaryVertices__PAT. 945.59 536.574
patPhotons_slimmedPhotons__PAT. 1644.4 522.335
recoConversions_reducedEgamma_reducedConversions_PAT. 2615.36 483.861
recoCaloClusters_reducedEgamma_reducedEBEEClusters_PAT. 1164.7 421.791
patJets_slimmedJetsCA8__PAT. 3520.31 376.554
patMETs_slimmedMETs__PAT. 1050.52 361.584
recoSuperClusters_reducedEgamma_reducedSuperClusters_PAT. 1231.65 357.525
recoCaloClusters_reducedEgamma_reducedESClusters_PAT. 697.286 223.275
EcalRecHitsSorted_reducedEgamma_reducedEERecHits_PAT. 364.949 175.89
recoVertexCompositePtrCandidates_slimmedSecondaryVertices__PAT. 430.899 170.706
EcalRecHitsSorted_reducedEgamma_reducedESRecHits_PAT. 329.665 104.847
patPackedCandidates_lostTracks__PAT. 183.553 63.832
edmTriggerResults_TriggerResults__HLT. 981.888 59.2852
recoConversions_reducedEgamma_reducedSingleLegConversions_PAT. 285.201 41.9809
patPackedTriggerPrescales_patTrigger__PAT. 1843 35.6586
EventAuxiliary 129.515 24.7287
recoPhotonCores_reducedEgamma_reducedGedPhotonCores_PAT. 140.762 20.8121
recoGsfElectronCores_reducedEgamma_reducedGedGsfElectronCores_PAT. 83.0712 14.6695
recoBeamSpot_offlineBeamSpot__reRECO. 329.206 11.8898
double_fixedGridRhoFastjetCentralCalo__reRECO. 9.77802 8.05318
double_fixedGridRhoFastjetCentralChargedPileUp__reRECO. 9.8222 7.97955
double_fixedGridRhoFastjetAllCalo__reRECO. 9.75839 7.95719
double_fixedGridRhoFastjetCentralNeutral__reRECO. 9.79275 7.9501
double_fixedGridRhoFastjetAll__reRECO. 9.73875 7.91683
double_fixedGridRhoAll__reRECO. 9.70439 4.45296
edmTriggerResults_TriggerResults__PAT. 101.028 3.44341
EventSelections 107.459 2.64194
doubles_ak5PFJetsCHS_rhos_reRECO. 15.7614 1.85956
doubles_ak5TrackJets_rhos_reRECO. 15.7614 1.85956
doubles_ak5CaloJets_rhos_reRECO. 15.7562 1.8522
doubles_ak5PFJets_rhos_reRECO. 15.7458 1.84183
BranchListIndexes 22.2716 1.32615
EventProductProvenance 16.2569 1.14753
double_ak5PFJetsCHS_rho_reRECO. 9.70439 0.866376
double_ak5TrackJets_rho_reRECO. 9.70439 0.866376
double_ak5CaloJets_rho_reRECO. 9.69948 0.861467
double_ak5PFJets_rho_reRECO. 9.68966 0.85165

@bendavid
Copy link
Author

rebased and merged with the common customize functions

@bendavid
Copy link
Author

(also, let me know to which branch I should make the pull request for 71x)

#
process.selectedPatJets.cut = cms.string("pt > 10")
process.selectedPatMuons.cut = cms.string("pt > 5 || isPFMuon || (pt > 3 && (isGlobalMuon || isStandAloneMuon || numberOfMatches > 0 || muonID('RPCMuLoose')))")
process.selectedPatElectrons.cut = cms.string("")
process.selectedPatTaus.cut = cms.string("pt > 20 && tauID('decayModeFinding')> 0.5")
process.selectedPatPhotons.cut = cms.string("pt > 15 && hadTowOverEm()<0.15 ")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we still had this selection!? looks like a bug no?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah no it was the final suggestion from susy

@bendavid
Copy link
Author

Last commits almost fully restore old behaviour.

Supercluster and seed cluster are now kept for all stored electrons and photons. (And detid/fraction vector in the supercluster is zeroed in case the subclusters and rechits are not being kept, as was discussed previously, but I'm not sure if it was ever implemented)

Zeroing of internal information for the loose candidates is also turned back on in the slimming configs.

(the change of pt>15 -> pt>14 for the photons is retained though)

Re-running the event size check now.

@bendavid
Copy link
Author

Total event size basically unchanged for ttbar (currently 30.0kB/event)

Branch Name | Average Uncompressed Size (Bytes/Event) | Average Compressed Size (Bytes/Event)
patPackedCandidates_packedPFCandidates__PAT. 63407.9 13298.6
patPackedGenParticles_packedGenParticles__PAT. 27189.8 3235.79
patMuons_slimmedMuons__PAT. 5750.56 1982.37
patTriggerObjectStandAlones_selectedPatTrigger__PAT. 29578.6 1920.84
patJets_slimmedJets__PAT. 15412.9 1358.35
patElectrons_slimmedElectrons__PAT. 4979.37 1314.25
recoGenParticles_prunedGenParticles__PAT. 4642.87 964.935
EcalRecHitsSorted_reducedEgamma_reducedEBRecHits_PAT. 1727.6 706.666
recoVertexs_offlineSlimmedPrimaryVertices__PAT. 1192.98 670.998
patPhotons_slimmedPhotons__PAT. 1740.7 583.688
patTaus_slimmedTaus__PAT. 5027.48 582.404
recoCaloClusters_reducedEgamma_reducedEBEEClusters_PAT. 1494.31 537.223
recoConversions_reducedEgamma_reducedConversions_PAT. 2880.32 512.647
recoSuperClusters_reducedEgamma_reducedSuperClusters_PAT. 1532.15 440.035
patMETs_slimmedMETs__PAT. 1252.47 435.717
patJets_slimmedJetsCA8__PAT. 2603.95 316.849
recoGenJets_slimmedGenJets__PAT. 773.894 262.235
recoVertexCompositePtrCandidates_slimmedSecondaryVertices__PAT. 602.536 239.896
recoCaloClusters_reducedEgamma_reducedESClusters_PAT. 968.314 228.444
EcalRecHitsSorted_reducedEgamma_reducedEERecHits_PAT. 496.748 223.708
EcalRecHitsSorted_reducedEgamma_reducedESRecHits_PAT. 415.548 127.525
patPackedCandidates_lostTracks__PAT. 229.879 87.6271
L1GlobalTriggerReadoutRecord_gtDigis__HLT. 1953.28 80.3366
GenEventInfoProduct_generator__SIM. 192.657 73.11
edmTriggerResults_TriggerResults__HLT. 989.353 71.1343
l1extraL1MuonParticles_l1extraParticles__HLT. 208.584 44.3493
recoConversions_reducedEgamma_reducedSingleLegConversions_PAT. 285.915 42.3354
l1extraL1EtMissParticles_l1extraParticles_MET_HLT. 179.732 28.5632
l1extraL1EtMissParticles_l1extraParticles_MHT_HLT. 179.732 27.4086
l1extraL1JetParticles_l1extraParticles_Central_HLT. 251.243 27.0682
l1extraL1EmParticles_l1extraParticles_NonIsolated_HLT. 265.179 26.75
l1extraL1EmParticles_l1extraParticles_Isolated_HLT. 296.848 24.7758
l1extraL1JetParticles_l1extraParticles_Tau_HLT. 183.602 22.5082
PileupSummaryInfos_addPileupInfo__HLT. 456.194 21.0844
recoPhotonCores_reducedEgamma_reducedGedPhotonCores_PAT. 150.338 20.8948
l1extraL1JetParticles_l1extraParticles_Forward_HLT. 139.431 20.868
recoGsfElectronCores_reducedEgamma_reducedGedGsfElectronCores_PAT. 113.388 18.0559
l1extraL1HFRingss_l1extraParticles__HLT. 102.924 8.84844
patPackedTriggerPrescales_patTrigger__PAT. 1856.3 8.42222
double_fixedGridRhoFastjetCentralChargedPileUp__RECO. 9.533 7.85433
double_fixedGridRhoFastjetCentralNeutral__RECO. 9.51167 7.833
double_fixedGridRhoFastjetAllCalo__RECO. 9.48678 7.80056
double_fixedGridRhoFastjetAll__RECO. 9.47256 7.77078
double_fixedGridRhoFastjetCentralCalo__RECO. 9.501 7.76633
recoBeamSpot_offlineBeamSpot__RECO. 325.571 7.67511
EventAuxiliary 129.247 4.82311
double_fixedGridRhoAll__RECO. 9.44767 4.241
edmTriggerResults_TriggerResults__PAT. 100.571 2.55822
EventSelections 90.2242 1.98656
doubles_ak5TrackJets_rhos_RECO. 15.4677 1.58989
doubles_ak5PFJetsCHS_rhos_RECO. 15.4677 1.58989
doubles_ak5CaloJets_rhos_RECO. 15.4641 1.58189
doubles_ak5PFJets_rhos_RECO. 15.457 1.57478
doubles_ak5GenJets_rhos_SIM. 15.457 1.57478
BranchListIndexes 22.1778 1.28989
EventProductProvenance 16.1861 1.18978
double_ak5TrackJets_rho_RECO. 9.44767 0.658778
double_ak5PFJetsCHS_rho_RECO. 9.44767 0.658778
double_ak5CaloJets_rho_RECO. 9.44411 0.655222
double_ak5PFJets_rho_RECO. 9.437 0.648111
double_ak5GenJets_rho_SIM. 9.437 0.648111

@arizzi
Copy link
Owner

arizzi commented Apr 30, 2014

do you have also a 71X version of the whole thing? or the rebasing should be trivial?

@bendavid
Copy link
Author

Rebasing should be trivial, (but there's one minor addition to be added to the ReducedEGProducer) I can do it once we're happy with the rest, just let me know which branch/release is most convenient to rebase onto.

@arizzi
Copy link
Owner

arizzi commented Apr 30, 2014

I got this

In file included from /afs/
cern.ch/cms/slc5_amd64_gcc481/external/clhep/2.1.3.1-cms/include/CLHEP/Vector/RotationX.icc:11:0
,
from /afs/
cern.ch/cms/slc5_amd64_gcc481/external/clhep/2.1.3.1-cms/include/CLHEP/Vector/RotationX.h:283
,
from /afs/
cern.ch/cms/slc5_amd64_gcc481/external/clhep/2.1.3.1-cms/include/CLHEP/Vector/Rotation.h:30
,
from /afs/
cern.ch/cms/slc5_amd64_gcc481/external/clhep/2.1.3.1-cms/include/CLHEP/Geometry/Transform3D.icc:6
,
from /afs/
cern.ch/cms/slc5_amd64_gcc481/external/clhep/2.1.3.1-cms/include/CLHEP/Geometry/Transform3D.h:840
,
from /afs/
cern.ch/cms/slc5_amd64_gcc481/cms/cmssw/CMSSW_7_0_0/src/Geometry/CaloGeometry/interface/CaloCellGeometry.h:8
,
from /afs/
cern.ch/cms/slc5_amd64_gcc481/cms/cmssw/CMSSW_7_0_0/src/Geometry/CaloGeometry/interface/CaloSubdetectorGeometry.h:11
,
from
/data/arizzi/microAOD/clean/CMSSW_7_0_0/src/RecoEgamma/EgammaPhotonProducers/src/ReducedEGProducer.cc:12:
/afs/
cern.ch/cms/slc5_amd64_gcc481/external/clhep/2.1.3.1-cms/include/CLHEP/Units/PhysicalConstants.h:
At global scope:
/afs/
cern.ch/cms/slc5_amd64_gcc481/external/clhep/2.1.3.1-cms/include/CLHEP/Units/PhysicalConstants.h:83:21:
error: 'CLHEP::electron_charge' defined but not used
[-Werror=unused-variable]
static const double electron_charge = - eplus; // see SystemOfUnits.h
^
cc1plus: some warnings being treated as errors
gmake: ***
[tmp/slc5_amd64_gcc481/src/RecoEgamma/EgammaPhotonProducers/src/RecoEgammaEgammaPhotonProducers/ReducedEGProducer.o]
Error 1
gmake: *** Waiting for unfinished jobs....
gmake: *** [There are compilation/build errors. Please see the detail log
above.] Error 2
99.194u 6.162s 0:18.55 567.9% 0+0k 0+0io 5147pf+0w
[cmspisa001] /data/arizzi/microAOD/clean/CMSSW_7_0_0/src $

On Wed, Apr 30, 2014 at 3:32 PM, Josh Bendavid notifications@github.comwrote:

Rebasing should be trivial, (but there's one minor addition to be added to
the ReducedEGProducer) I can do it once we're happy with the rest, just let
me know which branch/release is most convenient to rebase onto.


Reply to this email directly or view it on GitHubhttps://github.com//pull/24#issuecomment-41796243
.

@bendavid
Copy link
Author

I have seen this happen ~randomly in other cases also. Just try compiling again?

@arizzi
Copy link
Owner

arizzi commented May 1, 2014

In fact the error is still there (here more lines)... I suspect I miss
something in the sparse checkout list

Compiling edm plugin
/data/arizzi/microAOD/clean/CMSSW_7_0_0/src/RecoEgamma/EgammaPhotonProducers/src/ReducedEGProducer.cc
/data/arizzi/microAOD/clean/CMSSW_7_0_0/src/RecoEgamma/EgammaPhotonProducers/src/ReducedEGProducer.cc:
In member function 'virtual void ReducedEGProducer::produce(edm::Event&,
const edm::EventSetup&)':
/data/arizzi/microAOD/clean/CMSSW_7_0_0/src/RecoEgamma/EgammaPhotonProducers/src/ReducedEGProducer.cc:346:89:
error: no matching function for call to
'ConversionTools::matchesConversion(const reco::GsfElectron&, const
reco::Conversion&, bool, bool)'
bool matched =
ConversionTools::matchesConversion(gsfElectron,conversion,true,true);

         ^

/data/arizzi/microAOD/clean/CMSSW_7_0_0/src/RecoEgamma/EgammaPhotonProducers/src/ReducedEGProducer.cc:346:89:
note: candidates are:
In file included from
/data/arizzi/microAOD/clean/CMSSW_7_0_0/src/RecoEgamma/EgammaPhotonProducers/src/ReducedEGProducer.cc:44:0:
/afs/
cern.ch/cms/slc5_amd64_gcc481/cms/cmssw/CMSSW_7_0_0/src/RecoEgamma/EgammaTools/interface/ConversionTools.h:44:40:
note: static bool ConversionTools::matchesConversion(const
reco::GsfElectron&, const reco::Conversion&, bool)
static bool matchesConversion(const
reco::GsfElectron &ele, const reco::Conversion &conv, bool
allowCkfMatch=true);
^
/afs/
cern.ch/cms/slc5_amd64_gcc481/cms/cmssw/CMSSW_7_0_0/src/RecoEgamma/EgammaTools/interface/ConversionTools.h:44:40:
note: candidate expects 3 arguments, 4 provided
/afs/
cern.ch/cms/slc5_amd64_gcc481/cms/cmssw/CMSSW_7_0_0/src/RecoEgamma/EgammaTools/interface/ConversionTools.h:45:40:
note: static bool ConversionTools::matchesConversion(const
reco::SuperCluster&, const reco::Conversion&, float, float, float)
static bool matchesConversion(const
reco::SuperCluster &sc, const reco::Conversion &conv, float dRMax = 0.1,
float dEtaMax = 999., float dPhiMax = 999.);
^
/afs/
cern.ch/cms/slc5_amd64_gcc481/cms/cmssw/CMSSW_7_0_0/src/RecoEgamma/EgammaTools/interface/ConversionTools.h:45:40:
note: no known conversion for argument 1 from 'const reco::GsfElectron'
to 'const reco::SuperCluster&'
/afs/
cern.ch/cms/slc5_amd64_gcc481/cms/cmssw/CMSSW_7_0_0/src/RecoEgamma/EgammaTools/interface/ConversionTools.h:46:40:
note: static bool ConversionTools::matchesConversion(const
edm::RefToBasereco::Track&, const reco::Conversion&)
static bool matchesConversion(const
edm::RefToBasereco::Track &trk, const reco::Conversion &conv);
^
/afs/
cern.ch/cms/slc5_amd64_gcc481/cms/cmssw/CMSSW_7_0_0/src/RecoEgamma/EgammaTools/interface/ConversionTools.h:46:40:
note: candidate expects 2 arguments, 4 provided
/afs/
cern.ch/cms/slc5_amd64_gcc481/cms/cmssw/CMSSW_7_0_0/src/RecoEgamma/EgammaTools/interface/ConversionTools.h:47:40:
note: static bool ConversionTools::matchesConversion(const TrackRef&, const
reco::Conversion&)
static bool matchesConversion(const
reco::TrackRef &trk, const reco::Conversion &conv);
^
/afs/
cern.ch/cms/slc5_amd64_gcc481/cms/cmssw/CMSSW_7_0_0/src/RecoEgamma/EgammaTools/interface/ConversionTools.h:47:40:
note: candidate expects 2 arguments, 4 provided
/afs/
cern.ch/cms/slc5_amd64_gcc481/cms/cmssw/CMSSW_7_0_0/src/RecoEgamma/EgammaTools/interface/ConversionTools.h:48:40:
note: static bool ConversionTools::matchesConversion(const GsfTrackRef&,
const reco::Conversion&)
static bool matchesConversion(const
reco::GsfTrackRef &trk, const reco::Conversion &conv);
^

On Wed, Apr 30, 2014 at 5:13 PM, Josh Bendavid notifications@github.comwrote:

I have seen this happen ~randomly in other cases also. Just try compiling
again?


Reply to this email directly or view it on GitHubhttps://github.com//pull/24#issuecomment-41808817
.

@bendavid
Copy link
Author

bendavid commented May 1, 2014

So I wasn't using the sparse checkout list actually, but for this error I think you just need to add RecoEgamma/EgammaTools (where I indeed changed the signature for one of the functions)

@arizzi
Copy link
Owner

arizzi commented May 2, 2014

still...

Compiling edm plugin
/data/arizzi/microAOD/clean/CMSSW_7_0_0/src/RecoEgamma/EgammaPhotonProducers/src/TrackProducerWithSCAssociation.cc
Compiling edm plugin
/data/arizzi/microAOD/clean/CMSSW_7_0_0/src/RecoEgamma/EgammaTools/plugins/EGEnergyAnalyzer.cc
/data/arizzi/microAOD/clean/CMSSW_7_0_0/src/RecoEgamma/EgammaPhotonProducers/src/ReducedEGProducer.cc:
In member function 'virtual void ReducedEGProducer::produce(edm::Event&,
const edm::EventSetup&)':
/data/arizzi/microAOD/clean/CMSSW_7_0_0/src/RecoEgamma/EgammaPhotonProducers/src/ReducedEGProducer.cc:387:20:
error: 'class reco::SuperCluster' has no member named
'clearHitsAndFractions'
superCluster.clearHitsAndFractions();
^
Compiling edm plugin
/data/arizzi/microAOD/clean/CMSSW_7_0_0/src/RecoEgamma/EgammaTools/plugins/PhotonConversionMVAComputerCondUtilities.cc
Compiling edm plugin
/data/arizzi/microAOD/clean/CMSSW_7_0_0/src/RecoEgamma/EgammaTools/test/GBRWrapperMaker.cc
In file included from /afs/
cern.ch/cms/slc5_amd64_gcc481/external/clhep/2.1.3.1-cms/include/CLHEP/Vector/RotationX.icc:11:0
,
from /afs/
cern.ch/cms/slc5_amd64_gcc481/external/clhep/2.1.3.1-cms/include/CLHEP/Vector/RotationX.h:283
,
from /afs/
cern.ch/cms/slc5_amd64_gcc481/external/clhep/2.1.3.1-cms/include/CLHEP/Vector/Rotation.h:30
,
from /afs/
cern.ch/cms/slc5_amd64_gcc481/external/clhep/2.1.3.1-cms/include/CLHEP/Geometry/Transform3D.icc:6
,
from /afs/
cern.ch/cms/slc5_amd64_gcc481/external/clhep/2.1.3.1-cms/include/CLHEP/Geometry/Transform3D.h:840
,
from /afs/
cern.ch/cms/slc5_amd64_gcc481/cms/cmssw/CMSSW_7_0_0/src/Geometry/CaloGeometry/interface/CaloCellGeometry.h:8
,
from /afs/
cern.ch/cms/slc5_amd64_gcc481/cms/cmssw/CMSSW_7_0_0/src/Geometry/CaloGeometry/interface/CaloSubdetectorGeometry.h:11
,
from
/data/arizzi/microAOD/clean/CMSSW_7_0_0/src/RecoEgamma/EgammaPhotonProducers/src/ReducedEGProducer.cc:12:
/afs/
cern.ch/cms/slc5_amd64_gcc481/external/clhep/2.1.3.1-cms/include/CLHEP/Units/PhysicalConstants.h:
At global scope:
/afs/
cern.ch/cms/slc5_amd64_gcc481/external/clhep/2.1.3.1-cms/include/CLHEP/Units/PhysicalConstants.h:83:21:
error: 'CLHEP::electron_charge' defined but not used
[-Werror=unused-variable]
static const double electron_charge = - eplus; // see SystemOfUnits.h
^
cc1plus: some warnings being treated as errors
Subsystem RecoEcal built

On Thu, May 1, 2014 at 10:33 AM, Josh Bendavid notifications@github.comwrote:

So I wasn't using the sparse checkout list actually, but for this error I
think you just need to add RecoEgamma/EgammaTools (where I indeed changed
the signature for one of the functions)


Reply to this email directly or view it on GitHubhttps://github.com//pull/24#issuecomment-41890841
.

@bendavid
Copy link
Author

bendavid commented May 2, 2014

DataFormats/EgammaReco... (needed to add a setter to the SuperCluster)

@bendavid
Copy link
Author

bendavid commented May 2, 2014

(and similarly in DataFormats/EgammaCandidates)

@arizzi
Copy link
Owner

arizzi commented May 8, 2014

Hi Josh,
can you rebase and make new PR on the two part3 branches (for 71X and 70X):
miniAOD-from710p7-part3
miniAOD-from704-part3

Ciao
Andrea

arizzi pushed a commit that referenced this pull request Jan 20, 2015
arizzi added a commit that referenced this pull request Mar 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants