Skip to content
This repository has been archived by the owner on May 18, 2022. It is now read-only.

Update deps #304

Closed
wants to merge 4 commits into from
Closed

Update deps #304

wants to merge 4 commits into from

Conversation

KyleMaas
Copy link
Collaborator

@KyleMaas KyleMaas commented Jul 3, 2021

Attempt at updating deeper dependencies. Haven't tested it thoroughly yet.

Partial fix for #301 - gets rid of one vulnerability.

@KyleMaas
Copy link
Collaborator Author

KyleMaas commented Jul 5, 2021

So far this seems to be working okay for me. Looks like we got another vulnerability in the last few days, though.

@KyleMaas
Copy link
Collaborator Author

KyleMaas commented Jul 5, 2021

Updated ToastUI to get rid of that error, ran another round of updates. And I was wrong about that other vulnerability - turns out that audit was from a different branch, so it's one of the ones this fixes.

However, I now get the following errors logged to the console:

bundle-ui.js:127402 Uncaught RangeError: Maximum call stack size exceeded
    at bundle-ui.js:127402
    at syncMessages (bundle-ui.js:143374)
    at bundle-ui.js:143418
    at bundle-ui.js:127401
    at bundle-ui.js:127408
    at syncMessages (bundle-ui.js:143374)
    at bundle-ui.js:143414
    at bundle-ui.js:127401
    at bundle-ui.js:127408
    at syncMessages (bundle-ui.js:143374)
(anonymous) @ bundle-ui.js:127402
syncMessages @ bundle-ui.js:143374
(anonymous) @ bundle-ui.js:143418
(anonymous) @ bundle-ui.js:127401
(anonymous) @ bundle-ui.js:127408
syncMessages @ bundle-ui.js:143374
(anonymous) @ bundle-ui.js:143414
(anonymous) @ bundle-ui.js:127401
(anonymous) @ bundle-ui.js:127408
syncMessages @ bundle-ui.js:143374
(anonymous) @ bundle-ui.js:143410
(anonymous) @ bundle-ui.js:127401
(anonymous) @ bundle-ui.js:127365
next @ bundle-ui.js:127396
next @ bundle-ui.js:127396
next @ bundle-ui.js:127396
next @ bundle-ui.js:127137
sink @ bundle-ui.js:127158
pull @ bundle-ui.js:127088
syncFeed @ bundle-ui.js:143407
runQueue @ bundle-ui.js:143517
(anonymous) @ bundle-ui.js:143519
(anonymous) @ bundle-ui.js:143425
(anonymous) @ bundle-ui.js:127245
(anonymous) @ bundle-ui.js:127141
(anonymous) @ bundle-ui.js:127397
(anonymous) @ bundle-ui.js:127397
(anonymous) @ bundle-ui.js:127397
(anonymous) @ bundle-ui.js:127363
next @ bundle-ui.js:127396
next @ bundle-ui.js:127396
next @ bundle-ui.js:127396
next @ bundle-ui.js:127137
sink @ bundle-ui.js:127158
pull @ bundle-ui.js:127088
syncFeed @ bundle-ui.js:143407
runQueue @ bundle-ui.js:143517
(anonymous) @ bundle-ui.js:143519
(anonymous) @ bundle-ui.js:143425
(anonymous) @ bundle-ui.js:127245
(anonymous) @ bundle-ui.js:127141
(anonymous) @ bundle-ui.js:127397
(anonymous) @ bundle-ui.js:127397
(anonymous) @ bundle-ui.js:127397
(anonymous) @ bundle-ui.js:127363
next @ bundle-ui.js:127396
next @ bundle-ui.js:127396
next @ bundle-ui.js:127396
next @ bundle-ui.js:127137
sink @ bundle-ui.js:127158
pull @ bundle-ui.js:127088
syncFeed @ bundle-ui.js:143407
runQueue @ bundle-ui.js:143517
(anonymous) @ bundle-ui.js:143519
(anonymous) @ bundle-ui.js:143425
(anonymous) @ bundle-ui.js:127245
(anonymous) @ bundle-ui.js:127141
(anonymous) @ bundle-ui.js:127397
(anonymous) @ bundle-ui.js:127397
(anonymous) @ bundle-ui.js:127397
(anonymous) @ bundle-ui.js:127363
next @ bundle-ui.js:127396
next @ bundle-ui.js:127396
next @ bundle-ui.js:127396
next @ bundle-ui.js:127137
sink @ bundle-ui.js:127158
pull @ bundle-ui.js:127088
syncFeed @ bundle-ui.js:143407
runQueue @ bundle-ui.js:143517
(anonymous) @ bundle-ui.js:143519
(anonymous) @ bundle-ui.js:143425
(anonymous) @ bundle-ui.js:127245
(anonymous) @ bundle-ui.js:127141
(anonymous) @ bundle-ui.js:127397
(anonymous) @ bundle-ui.js:127397
(anonymous) @ bundle-ui.js:127397
(anonymous) @ bundle-ui.js:127363
next @ bundle-ui.js:127396
next @ bundle-ui.js:127396
next @ bundle-ui.js:127396
next @ bundle-ui.js:127137
sink @ bundle-ui.js:127158
pull @ bundle-ui.js:127088
syncFeed @ bundle-ui.js:143407
runQueue @ bundle-ui.js:143517
(anonymous) @ bundle-ui.js:143519
(anonymous) @ bundle-ui.js:143425
(anonymous) @ bundle-ui.js:127245
(anonymous) @ bundle-ui.js:127141
(anonymous) @ bundle-ui.js:127397
(anonymous) @ bundle-ui.js:127397
(anonymous) @ bundle-ui.js:127397
(anonymous) @ bundle-ui.js:127363
next @ bundle-ui.js:127396
next @ bundle-ui.js:127396
next @ bundle-ui.js:127396
next @ bundle-ui.js:127137
sink @ bundle-ui.js:127158
pull @ bundle-ui.js:127088
syncFeed @ bundle-ui.js:143407
runQueue @ bundle-ui.js:143517
(anonymous) @ bundle-ui.js:143519
(anonymous) @ bundle-ui.js:143425
(anonymous) @ bundle-ui.js:127245
(anonymous) @ bundle-ui.js:127141
(anonymous) @ bundle-ui.js:127397
(anonymous) @ bundle-ui.js:127397
(anonymous) @ bundle-ui.js:127397
(anonymous) @ bundle-ui.js:127363
next @ bundle-ui.js:127396
next @ bundle-ui.js:127396
next @ bundle-ui.js:127396
next @ bundle-ui.js:127137
sink @ bundle-ui.js:127158
pull @ bundle-ui.js:127088
syncFeed @ bundle-ui.js:143407
runQueue @ bundle-ui.js:143517
(anonymous) @ bundle-ui.js:143519
(anonymous) @ bundle-ui.js:143425
(anonymous) @ bundle-ui.js:127245
(anonymous) @ bundle-ui.js:127141
(anonymous) @ bundle-ui.js:127397
(anonymous) @ bundle-ui.js:127397
(anonymous) @ bundle-ui.js:127397
(anonymous) @ bundle-ui.js:127363
next @ bundle-ui.js:127396
next @ bundle-ui.js:127396
next @ bundle-ui.js:127396
next @ bundle-ui.js:127137
sink @ bundle-ui.js:127158
pull @ bundle-ui.js:127088
syncFeed @ bundle-ui.js:143407
runQueue @ bundle-ui.js:143517
(anonymous) @ bundle-ui.js:143519
(anonymous) @ bundle-ui.js:143425
(anonymous) @ bundle-ui.js:127245
(anonymous) @ bundle-ui.js:127141
(anonymous) @ bundle-ui.js:127397
(anonymous) @ bundle-ui.js:127397
(anonymous) @ bundle-ui.js:127397
(anonymous) @ bundle-ui.js:127363
next @ bundle-ui.js:127396
next @ bundle-ui.js:127396
next @ bundle-ui.js:127396
next @ bundle-ui.js:127137
sink @ bundle-ui.js:127158
pull @ bundle-ui.js:127088
syncFeed @ bundle-ui.js:143407
runQueue @ bundle-ui.js:143517
(anonymous) @ bundle-ui.js:143519
(anonymous) @ bundle-ui.js:143425
(anonymous) @ bundle-ui.js:127245
(anonymous) @ bundle-ui.js:127141
(anonymous) @ bundle-ui.js:127397
(anonymous) @ bundle-ui.js:127397
(anonymous) @ bundle-ui.js:127397
(anonymous) @ bundle-ui.js:127363
next @ bundle-ui.js:127396
next @ bundle-ui.js:127396
next @ bundle-ui.js:127396
next @ bundle-ui.js:127137
sink @ bundle-ui.js:127158
pull @ bundle-ui.js:127088
syncFeed @ bundle-ui.js:143407
runQueue @ bundle-ui.js:143517
(anonymous) @ bundle-ui.js:143519
(anonymous) @ bundle-ui.js:143425
(anonymous) @ bundle-ui.js:127245
(anonymous) @ bundle-ui.js:127141
(anonymous) @ bundle-ui.js:127397
(anonymous) @ bundle-ui.js:127397
(anonymous) @ bundle-ui.js:127397
(anonymous) @ bundle-ui.js:127363
next @ bundle-ui.js:127396
next @ bundle-ui.js:127396
next @ bundle-ui.js:127396
next @ bundle-ui.js:127137
sink @ bundle-ui.js:127158
pull @ bundle-ui.js:127088
syncFeed @ bundle-ui.js:143407
runQueue @ bundle-ui.js:143517
(anonymous) @ bundle-ui.js:143519
(anonymous) @ bundle-ui.js:143425
(anonymous) @ bundle-ui.js:127245
(anonymous) @ bundle-ui.js:127141
(anonymous) @ bundle-ui.js:127397
(anonymous) @ bundle-ui.js:127397
(anonymous) @ bundle-ui.js:127397
(anonymous) @ bundle-ui.js:127363
next @ bundle-ui.js:127396
next @ bundle-ui.js:127396
next @ bundle-ui.js:127396
next @ bundle-ui.js:127137
sink @ bundle-ui.js:127158
pull @ bundle-ui.js:127088
syncFeed @ bundle-ui.js:143407
runQueue @ bundle-ui.js:143517
(anonymous) @ bundle-ui.js:143519
(anonymous) @ bundle-ui.js:143425
(anonymous) @ bundle-ui.js:127245
Show 170 more frames
bundle-ui.js:149504 rpc.ebt.replicate exception: [object Object]

Also, I get this whether I run it in a private tab or not:

bundle-ui.js:84614 lossy store has no fs access, skipping persistence

@arj03
Copy link
Owner

arj03 commented Jul 5, 2021

lossy store has no fs access, skipping persistence

That error is from ssb-ebt, it should be harmless.

I don't understand the other bug.

I tried doing a npm upgrade toast + dedupe. Seems to be running fine here.

@arj03
Copy link
Owner

arj03 commented Jul 5, 2021

I general not super excited about these huge npm upgrades, as so many things can go wrong and the gains seems to be rather small.

@KyleMaas
Copy link
Collaborator Author

KyleMaas commented Jul 5, 2021

In general, I would agree. My rationale for this is as follows:

  1. We've already got huge changes with the unbermuda stuff. We might as well make sure that all still works with newer dependencies as well, provided they're still within the ranges we're specifying. If something's broken, then it should be either fixed or the package.json requirements of that dependency need to be pinned to a version instead of relying on shrinkwrap. Otherwise if someone else tries to build something using those libraries and doesn't start with the same shrinkwrap, they could have problems we don't.
  2. As packages are upgraded, they quite often require newer sub-dependencies. That was one of the things I found with the previous deduplication efforts. By bringing more things closer to current, you have a better shot at the sub-dependencies lining up so they can be deduplicated.

@arj03
Copy link
Owner

arj03 commented Jul 6, 2021

Looking at that error again, it should not be related to these bumps. Instead its the new sync module I built: https://github.com/arj03/ssb-browser-core/blob/master/feed-replication.js. I'll move the error over to core.

@arj03 arj03 closed this Oct 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KyleMaas @arj03