Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix negative deadline bug #8

Merged
merged 1 commit into from
Feb 13, 2022
Merged

Fix negative deadline bug #8

merged 1 commit into from
Feb 13, 2022

Conversation

arjun-1
Copy link
Owner

@arjun-1 arjun-1 commented Feb 13, 2022

  • Fix negative deadline bug
  • Pin golang version
  • rename reader and writer creator
  • update wasm_exec.js
  • add logging functionality to reader and writer
  • better error reporting in case of write error

* Fix negative deadline bug
* Pin golang version
* rename reader and writer creator
* update wasm_exec.js
* add logging functionality to reader and writer
* better error reporting in case of write error
@arjun-1 arjun-1 force-pushed the fix-negative-deadline-bug branch from 7c950f3 to a9100ba Compare February 13, 2022 19:55
@codecov
Copy link

codecov bot commented Feb 13, 2022

Codecov Report

Merging #8 (a9100ba) into master (3d302a3) will decrease coverage by 0.01%.
The diff coverage is 90.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
- Coverage   63.65%   63.63%   -0.02%     
==========================================
  Files          10       10              
  Lines        1051     1056       +5     
  Branches       10       10              
==========================================
+ Hits          669      672       +3     
- Misses        382      384       +2     
Impacted Files Coverage Δ
lib/wasm_exec.js 58.86% <25.00%> (-0.16%) ⬇️
mod.ts 87.69% <100.00%> (ø)
net/node-connection.ts 76.41% <100.00%> (-0.23%) ⬇️
net/util.ts 84.61% <100.00%> (ø)
test/integration/setup.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77e42bf...a9100ba. Read the comment docs.

@arjun-1 arjun-1 merged commit 2026f54 into master Feb 13, 2022
@arjun-1 arjun-1 deleted the fix-negative-deadline-bug branch February 13, 2022 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant