Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension host terminated unexpectedly #410

Open
Graham42 opened this issue Jul 29, 2019 · 14 comments
Open

Extension host terminated unexpectedly #410

Graham42 opened this issue Jul 29, 2019 · 14 comments
Labels
backlog Issue is in the backlog, will be picked up bug Something isn't working

Comments

@Graham42
Copy link

I kept seeing this error when I started VS Code. Searching the issues I found
microsoft/vscode#77099 and a suggestion to disable chat which worked for me. So it seems likely that the cause of microsoft/vscode#77099 is this extension.

Possibly related:

It's also possibly not this extension. But it's a common element and disabling / uninstalling seems to fix.

@arjunattam arjunattam added backlog Issue is in the backlog, will be picked up bug Something isn't working labels Aug 5, 2019
@arjunattam
Copy link
Owner

Thanks for reporting @Graham42, will investigate this

@arjunattam
Copy link
Owner

arjunattam commented Aug 15, 2019

This one has been a bit hard to repro, but I was able to verify this on one machine. Disabling the extension does prevent the extension host from crashing again. It seems the extension is doing something during activation which crashes the host.

While debugging, I tried to uninstall and reinstall the extension, and weirdly, that fixed the issue for me. I'm not suggesting that is the fix, but it would be useful to know if that fixes the issue for you as well. Will help me debug the issue.

@mjolka
Copy link

mjolka commented Aug 15, 2019

Uninstalling and reinstalling did not fix the issue for me. Please let me know if there's any information I can provide to help debug this.

@arjunattam
Copy link
Owner

Thanks! Are you on Windows? Are you using Slack/Discord/VS Live Share?

My current understanding is that this is happening right after VS Code starts up, and leads to the extension host crashing. Disabling the chat extension fixes it. Is that how it is working for you? What happens if you disable the Live Share extension instead of the chat extension?

@mjolka
Copy link

mjolka commented Aug 15, 2019

  • Yes, I'm on Windows 10 (version 1803).
  • I'm running Slack (Production 4.0.1 64-bit).
  • Yes, this happens right after VS Code starts up and leads to the extension host crashing.
  • Yes, disabling Live Share Chat fixes it.
  • Yes, disabling Live Share fixes it (I had to disable Live Share Audio as well).

vIRWJUxssT

@arjunattam
Copy link
Owner

Thank you, @mjolka, this helps a lot. I have a theory on why this might be happening, and I have created 2 builds of the extension to validate that. These builds are available here.

Would it be possible for you to install them one by one and see if the issue is fixed by either of them? In these tests, please enable the Live Share and Live Share Audio extensions. Thanks again for your help!!

@mjolka
Copy link

mjolka commented Aug 15, 2019

Hi @arjun27 , I'm afraid that neither build fixed the issue.

@arjunattam
Copy link
Owner

Thanks a lot for checking @mjolka. I just uploaded another build - chat-0.20.2-no-vsls.vsix. Can you try it?

@mjolka
Copy link

mjolka commented Aug 15, 2019

chat-0.20.2-no-vsls.vsix still has the issue.

@arjunattam
Copy link
Owner

Thanks again for testing. I just uploaded chat-0.20.2-no-vsls-v2.vsix with some more changes

@mjolka
Copy link

mjolka commented Aug 15, 2019

I wish I could give you better news, but the issue is still there in chat-0.20.2-no-vsls-v2.vsix.

@arjunattam
Copy link
Owner

Thanks @mjolka.

I've uploaded 2 more builds to debug this: chat-0.21.0-vsls.vsix and chat-0.21.0-keytar.vsix. These are available in this shared folder. Would it be possible to see if any of them fix the issue for you? Thanks again!

@mjolka
Copy link

mjolka commented Aug 19, 2019

Hi @arjun27. Unfortunately neither build fixed the issue.

After trying them both out I uninstalled some other extensions and now I am unable to reproduce the issue consistently, even with the official build (0.20.2). I didn't keep a list of which extensions I uninstalled. The only time I have been able to see the crash again was right after reinstalling Peacock. My apologies, I'll let you know I can get the issue happening reliably again.

@robertsimmons
Copy link

Was directed here from a bug I had opened on the VSCode github page.

With the chat extension enabled, clicking the diff in a git repo for that snapshot file always crashed the extension host. With it disabled, it does not crash. However, some things still lag a lot when selecting them in the editor, and I get this log message in "Log (Window)": "[warning] UNRESPONSIVE extension host, 'CoenraadS.bracket-pair-colorizer' took 97% of 5792ms, saved PROFILE here: 'C:\Users\Rob\AppData\Local\Temp\exthost-b8041d.cpuprofile' [{"id":"CoenraadS.bracket-pair-colorizer","total":5600000,"percentage":97},{"id":"gc","total":192000,"percentage":3}]"

I don't know if that plugin is misbehaving with VSLS potentially, but thought I'd inform you guys as it might help track down your issue.

I'll probably go ahead and uninstall all the VSLS stuff for now (installed it for a previous team, not using it on current team).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Issue is in the backlog, will be picked up bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants