-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
critical: Extension host crash #91
Comments
If you see this again, could you click the “Open Developer Tools” button in the toast and share any error messages you see? Otherwise, we’ll look into this ASAP! |
will do. I noticed it happen right after your sockets connect debug msgs from communities ext. a few times. should have clipped dev tools messages too. |
actually, it's hard to tell what's causing it from dev tools console trace. I see todo-tree errors there (just another ext. I use that used to be stable in prior vscode releases), then sudden ext. service termination after vscode-icons load. I could try disabling some of those extensions to help you || vscode team troubleshoot this. Might be a generic issue in the last vscode v1.38 update: |
I see this a lot and don't think it is related to the communities extension. No extension can cause the extension host activation failure so looks like a VSCode issue to me. |
@legomushroom that's an interesting comment. 1st time I've seen this issue crop up was in vscode v1.38 update & I've been playing with code extensions for about a year now. Can you please notify proper authorities at vscode team, ref. this ticket & close it in your repo? Thanks for confirming it's not rare. |
The extension host has already been activated, otherwise you wouldn't see messages like "you extension 'foobar' is now active!". That means something is happening and it's likely loading or running an extension which causes the crash. What's also suspicious is that it tries to attached the debugger. This usually happens when the extension host becomes unresponsive and when automatic profiling is started. So, I would still bet on an extension that runs endless loops or allocates endless memory. Can you attach the reading from the extension host log: "F1 > Show Log > Extension Host" fyi @alexandrudima who has investigates crashed before and knows the common crasher extensions. |
interesting. my next call to troubleshoot this was disable all extensions & enable them 1 by 1, but that can take a whole day. @jrieken are you saying you have not seen this issue crop up in your last v1.38 vscode release? 1st time when I started seeing it. I also never seen an extension take down an ext. host. That's some next level matrix bit (cc @legomushroom :) Do you have some examples of such extensions to help us troubleshoot this further? I'd still prefer to transfer it to you vscode repo & track it there. I logged it here only becase vsls was the last pack I enabled after vscode v1.38 update ... |
@jrieken && @alexandrudima anyhoo, here is my fresh F1 -> Developer>Show Logs... Extension Host log (I just replaced my win user dir with blank :)
Does this help in any way? |
@jrieken the extension host indeed activates but then terminates unexpectedly after some time. Extension host logs:
Hope it helps. |
@legomushroom not really. I could not even parse your long log. can you reformat it similar to how I did mine? this is fun! ;) |
This might be microsoft/vscode#77099 (comment) which has been reported before. |
so what's the solution then? should this be moved to vsls chat to get worked on? per comments in that vscode ticket. I mean we can't just disable chat to prevent these crashes, if we want to use live share and that's what's causing it. |
I found this extensive writeup really on point: microsoft/vscode#79782 and I do believe it's caused by vsls extensions in my case since I have not seen these crashes until I enabled vsls pack. |
@RandomFractals if you could scope down to a particular extension inside the vsls extension pack, that would be extremely helpful. |
@legomushroom good idea. will try to do that today/tomorrow since I'd like to use vsls, even plan to add it to my data preview ext. soon. will let you know if I can narrow it down, but I still suspect it's chat. |
@legomushroom @lostintangent & @jrieken so... I just banged out this async data load bit w/o vsls extensions enabled & have not seen a single ext. host crash: https://github.com/RandomFractals/vscode-data-preview/releases/tag/v1.42.0 & my ext. is super heavy too using large Arrow data files, fs & wasm for all that data display, if you have not checked it out yet. I can dork a bit more with your chat & comms comps, but sounds to me you really question it's caused by your vsls extensions. Not sure I can provide more proof that it is. Should I pop that hood and dive deeper? p.s: also, do you guys do code/bug bounties yet? I think this is 1 of them you should def. throw some $$$ at for other devs to recon. PR the fix for something this heavy is not fun for any 'code/TS/C' expirienced dev. your call! |
related: arjunattam/vscode-chat#410 |
Closing this since it’s potentially an issue with the Chat extension, not Spaces. |
too bad. you guys keep passing this ball from 1 repo to another for over a year now. just sad! |
@legomushroom & @cjiiing what are you confused about? has it been fixed for spaces || chat yet? ... |
either your new communities ext. or chat crashes extension host in vscode v1.38 on win & mac.
I thought it was just a fluke the other day, but I also had my remote dev bud using Mac confirming it.
what I get on win:
The text was updated successfully, but these errors were encountered: