Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tlm-cmd-code-generator example settings & docs #117

Merged
merged 5 commits into from
Oct 11, 2023

Conversation

sksat
Copy link
Member

@sksat sksat commented Oct 5, 2023

概要

tlm-cmd-code-generator の settings.json の例を example user 用に更新する

詳細

  • tlm-cmd-code-generator/settings.jsonexamples/mobc のための設定に書き換え,settings_mobc..json に rename した
  • examples/subobc のための設定を tlm-cmd-code-generator/settings_subobc.json として追加した
  • ドキュメントを更新

検証結果

コード生成して,diff が出なかった

影響範囲

@sksat sksat added enhancement New feature or request priority::medium priority medium tools labels Oct 5, 2023
@sksat sksat requested a review from meltingrabbit October 5, 2023 13:47
@sksat sksat self-assigned this Oct 5, 2023
@meltingrabbit
Copy link
Member

これって,各c2a user にも存在するファイルなので, src/user/settings かどこかに配置したほうが良い気がするんだけれども,どうですか?(このあと,各c2a user repository でも同様にやっていくことになるはずなので)

@sksat
Copy link
Member Author

sksat commented Oct 10, 2023

そもそも各 C2A user にも存在する,というのが現状では正しくないはずです.この PR は単に字面通りに c2a-core のためのアップデートです(tlm-cmd-code-generator の管理を c2a-core に移した以上,この example は c2a-core example user に寄せるのが自然なので)

@sksat
Copy link
Member Author

sksat commented Oct 11, 2023

rebase

@sksat sksat force-pushed the feature/update-tlm-cmd-code-generator-example branch from a3e33a3 to b5b598c Compare October 11, 2023 06:51
@sksat sksat changed the title Update tlm-cmd-code-generator example settings Update tlm-cmd-code-generator example settings & docs Oct 11, 2023
@sksat
Copy link
Member Author

sksat commented Oct 11, 2023

@meltingrabbit これでどうでしょう

@meltingrabbit
Copy link
Member

superよさそう

@sksat sksat merged commit 69abe51 into develop Oct 11, 2023
33 checks passed
@sksat sksat deleted the feature/update-tlm-cmd-code-generator-example branch October 11, 2023 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority::medium priority medium tools
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants