-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tlm-cmd-code-generator example settings & docs #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sksat
added
enhancement
New feature or request
priority::medium
priority medium
tools
labels
Oct 5, 2023
これって,各c2a user にも存在するファイルなので, src/user/settings かどこかに配置したほうが良い気がするんだけれども,どうですか?(このあと,各c2a user repository でも同様にやっていくことになるはずなので) |
そもそも各 C2A user にも存在する,というのが現状では正しくないはずです.この PR は単に字面通りに c2a-core のためのアップデートです(tlm-cmd-code-generator の管理を c2a-core に移した以上,この example は c2a-core example user に寄せるのが自然なので) |
rebase |
sksat
force-pushed
the
feature/update-tlm-cmd-code-generator-example
branch
from
October 11, 2023 06:51
a3e33a3
to
b5b598c
Compare
sksat
changed the title
Update tlm-cmd-code-generator example settings
Update tlm-cmd-code-generator example settings & docs
Oct 11, 2023
@meltingrabbit これでどうでしょう |
meltingrabbit
approved these changes
Oct 11, 2023
superよさそう |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
tlm-cmd-code-generator の
settings.json
の例を example user 用に更新する詳細
tlm-cmd-code-generator/settings.json
をexamples/mobc
のための設定に書き換え,settings_mobc..json
に rename したexamples/subobc
のための設定をtlm-cmd-code-generator/settings_subobc.json
として追加した検証結果
コード生成して,diff が出なかった
影響範囲