Refactor user cmake option #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sksat
added
enhancement
sksat
commented
Oct 12, 2023
examples/mobc/CMakeLists.txt
Outdated
| @@ -16,11 +16,11 @@ option(USE_SCI_COM_WINGS "Use SCI_COM_WINGS" ON) | |||
| # そちらのバッファが詰まってSILSの動作が止まることがあるので注意すること！ | |||
| option(USE_SCI_COM_UART "Use SCI_COM_UART" OFF) | |||
There was a problem hiding this comment.
USE_SCI_COM_WINGS と USE_SCI_COM_UART もどうにかしたい
- 今後は WINGS は optional な存在となるため，
USE_SCI_COM_WINGSは default OFF とする - SCI って何？
There was a problem hiding this comment.
SCI はルネサス語っぽい（Serial Communication Interface）
There was a problem hiding this comment.
やるなら
uart_sils_sci_if
ccsds_sils_sci_if
も同時に消したい
There was a problem hiding this comment.
この PR では一旦 C2A_ prefix だけ付ける
|
rebase |
sksat
force-pushed
the
feature/refactor-user-cmake-option
branch
from
50f9edb to
50abcaa
Compare
meltingrabbit
approved these changes
Oct 12, 2023
meltingrabbit
requested changes
Oct 12, 2023
|
workflows-c2a 側の対応は #136 で入る |
|
workflows-c2a の対応入ったので rebase |
sksat
force-pushed
the
feature/refactor-user-cmake-option
branch
from
44b8a0d to
32606b1
Compare
|
再度修正: #137 |
…> C2A_USE_SCI_COM_UART
|
rebase |
sksat
force-pushed
the
feature/refactor-user-cmake-option
branch
from
836b52c to
1a54a0e
Compare
meltingrabbit
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
#86 に引き続き，C2A user 側の CMake option についても整理する
Issue / PR
詳細
各 C2A user で実際にどのような CMake option が定義されているかは未知だが，#86 でコーディング規約を変更したため，コーディング規約に遵守している限りは，最低限 大文字の SNAKE_CASE で，
C2A_prefix に揃えているはず．この PR では，example user の CMake option を新しい規約に遵守させる．
検証結果
test へのリンクや，検証結果へのリンク
影響範囲