Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply rename migration: driver_instances -> component_service #144

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Apply rename migration: driver_instances -> component_service #144

merged 2 commits into from
Oct 13, 2023

Conversation

sksat
Copy link
Member

@sksat sksat commented Oct 13, 2023 •
edited by meltingrabbit
Loading

概要

#143 の migration を example user に適用した

Issue / PR

詳細

  • examples/mobc
  • examples/subobc

検証結果

  • CI が通った
  • テレコマDBの変更を確認した

影響範囲

テレコマDB・コマンド名

補足

beta release したい

@sksat sksat added enhancement New feature or request priority::high priorityg high labels Oct 13, 2023
@sksat sksat self-assigned this Oct 13, 2023
@sksat
Copy link
Member Author

sksat commented Oct 13, 2023

examples/mobc だけの変更だと subobc の pytest が疎通できなくてコケる

@sksat sksat requested a review from meltingrabbit October 13, 2023 06:21
@sksat sksat mentioned this pull request Oct 13, 2023
Merged
@sksat sksat force-pushed the feature/rename-driver-instance branch from 9ab2176 to 5baff90 Compare October 13, 2023 10:12
@sksat
Copy link
Member Author

sksat commented Oct 13, 2023

rebase & やり直し

@sksat sksat force-pushed the feature/rename-driver-instance-examples branch from 98de6a9 to fe9e0d1 Compare October 13, 2023 10:15
@sksat sksat force-pushed the feature/rename-driver-instance branch from 5baff90 to 1383946 Compare October 13, 2023 10:31
@sksat
Copy link
Member Author

sksat commented Oct 13, 2023

rebase & やり直し

@sksat sksat force-pushed the feature/rename-driver-instance-examples branch 2 times, most recently from 6639bd1 to c57d6b2 Compare October 13, 2023 11:00
@sksat sksat force-pushed the feature/rename-driver-instance branch from f57121b to 57cb2a7 Compare October 13, 2023 11:08
@sksat
Copy link
Member Author

sksat commented Oct 13, 2023

rebase & やり直し

@sksat sksat force-pushed the feature/rename-driver-instance-examples branch from b50f9ea to db91f9e Compare October 13, 2023 11:09
@meltingrabbit meltingrabbit mentioned this pull request Oct 13, 2023
Merged
2 tasks
@sksat sksat force-pushed the feature/rename-driver-instance-examples branch from 344e27a to 25cfcdd Compare October 13, 2023 11:16
@sksat sksat force-pushed the feature/rename-driver-instance-examples branch from 25cfcdd to 7cb7bfa Compare October 13, 2023 11:19
@meltingrabbit
Copy link
Member

手動がひつようなものはこっちで

@sksat
Copy link
Member Author

sksat commented Oct 13, 2023

beta release は #150 でやる

Base automatically changed from feature/rename-driver-instance to develop October 13, 2023 11:28
@sksat sksat merged commit 6e05d73 into develop Oct 13, 2023
35 checks passed
@sksat sksat deleted the feature/rename-driver-instance-examples branch October 13, 2023 11:28
@meltingrabbit meltingrabbit mentioned this pull request Nov 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meltingrabbit meltingrabbit meltingrabbit approved these changes

Assignees

@sksat sksat

Labels
enhancement New feature or request priority::high priorityg high
Projects
C2A public
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sksat @meltingrabbit