Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply rename migration: Driver -> Component Driver #147

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Apply rename migration: Driver -> Component Driver #147

merged 2 commits into from
Oct 13, 2023

Conversation

sksat
Copy link
Member

@sksat sksat commented Oct 13, 2023 •
edited
Loading

概要

#146 の migration を example user に適用する

Issue / PR

詳細

  • examples/mobc
  • examples/subobc

検証結果

CI が通ればよし

@sksat sksat added enhancement New feature or request priority::high priorityg high labels Oct 13, 2023
@sksat sksat requested a review from meltingrabbit October 13, 2023 08:51
@sksat sksat self-assigned this Oct 13, 2023
@sksat sksat force-pushed the feature/rename-driver2 branch from d0a3108 to 4144757 Compare October 13, 2023 09:34
@sksat
Copy link
Member Author

sksat commented Oct 13, 2023

rebase

@sksat sksat force-pushed the feature/rename-driver2-examples branch from 77c8c97 to 429b6de Compare October 13, 2023 09:37
@sksat
Copy link
Member Author

sksat commented Oct 13, 2023

migration script を更新しているので，apply し直し

@sksat sksat force-pushed the feature/rename-driver2-examples branch from 429b6de to 3cba875 Compare October 13, 2023 09:39
@sksat
Copy link
Member Author

sksat commented Oct 13, 2023

migration script バグってたのでやり直し

@sksat sksat force-pushed the feature/rename-driver2-examples branch from 71b9e28 to 58d487d Compare October 13, 2023 09:44
meltingrabbit
meltingrabbit approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@meltingrabbit meltingrabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ds などの local var や，indent などは別PRで直す

Base automatically changed from feature/rename-driver2 to develop October 13, 2023 10:11
@sksat sksat merged commit 7fb819a into develop Oct 13, 2023
35 checks passed
@sksat sksat deleted the feature/rename-driver2-examples branch October 13, 2023 10:11
@meltingrabbit meltingrabbit mentioned this pull request Oct 13, 2023
Merged
@meltingrabbit meltingrabbit mentioned this pull request Nov 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meltingrabbit meltingrabbit meltingrabbit approved these changes

Assignees

@sksat sksat

Labels
enhancement New feature or request priority::high priorityg high
Projects
C2A public
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sksat @meltingrabbit