-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Component Driver を統一的に c2a-core で扱えるようにし,CDS の tlm と,テレメ不通関連 Cmd を追加 #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meltingrabbit
added
enhancement
New feature or request
priority::medium
priority medium
labels
Dec 31, 2023
meltingrabbit
changed the base branch from
main
to
feature/rename_component_driver_super
December 31, 2023 18:14
1 task
meltingrabbit
force-pushed
the
feature/component_driver
branch
from
January 1, 2024 05:03
d91c5c9
to
d43e657
Compare
meltingrabbit
changed the base branch from
feature/rename_component_driver_super
to
feature/cleanup-driversuper
January 1, 2024 05:03
meltingrabbit
changed the title
WIP
Component Driver を統一的に c2a-core で扱えるようにし,CDS の tlm と,テレメ不通関連 Cmd を追加
Jan 1, 2024
@ToshiAki64 @hender14 レビューお願いします |
1 task
meltingrabbit
force-pushed
the
feature/cleanup-driversuper
branch
from
January 4, 2024 03:36
a4fa33b
to
44a5cb4
Compare
meltingrabbit
force-pushed
the
feature/component_driver
branch
from
January 4, 2024 03:37
0212d14
to
fdf0c26
Compare
meltingrabbit
force-pushed
the
feature/cleanup-driversuper
branch
from
January 4, 2024 09:02
44a5cb4
to
63afee6
Compare
meltingrabbit
force-pushed
the
feature/component_driver
branch
from
January 4, 2024 09:02
fdf0c26
to
d450ccb
Compare
ToshiAki64
reviewed
Jan 5, 2024
ToshiAki64
approved these changes
Jan 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
実装は、いいと思います。
core update時に、既存の処理がある user は、そのままでいいか。
バサッと、core の処理に切り替えるかなどの指針がどこかのドキュメントにあるといいかと。
meltingrabbit
force-pushed
the
feature/cleanup-driversuper
branch
from
January 5, 2024 06:03
63afee6
to
132a9c9
Compare
meltingrabbit
force-pushed
the
feature/component_driver
branch
from
January 5, 2024 06:06
d450ccb
to
5a6d9f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
Component Driver を統一的に c2a-core で扱えるようにし,CDS の tlm と,テレメ不通関連 Cmd を追加
Issue
詳細
CDRV の定義を user で設定することで,c2a core 側の App やコードで, CDRV を統一的に扱えるようにした.
それに伴い,各 CDRV の CDS のメンバをテレメで落とせるようにした.
さらに,テレメ不通関連の設定,有効化をできるようにした
検証結果
CI が通ればOK
補足