Rename tools dir to Boom tools #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
「C2A Boom」という単語がどこにも定義されてないので，簡易でもいいのでドキュメント書いてもらえないですか？ cf. #49 |
|
書くのはいいんですがこの PR のスコープ外です |
|
大賛成 |
|
はい．PR分けてもらってもいいのですが，v4.4.0 にいれるかどうか気になってます． |
|
この PR は現状の是正なので詳細を紹介するドキュメントが欲しい、という話は無関係です。C2A Boom という語自体は既に c2a-core の PR でも各 C2A user での実際の開発でも内部ドキュメントでも CHANGELOG にもあります。 |
|
ドキュメントの話とこの PR の話は別だが、ややユーザに驚きを与える可能性があるのとスケジュール的な観点から v4.4.0 の後にする |
|
rebase |
sksat
force-pushed
the
feature/rename-tools-dir-to-boom-tools
branch
from
d667f1f to
72f7f7c
Compare
KOBA789
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
C2A user の
toolsディレクトリをboom-toolsに rename する詳細
toolsは #56 で導入された C2A Boom のためのものであるため、名前で C2A Boom 関係のものだと明示するようにする検証結果
example user のディレクトリで
npm installして C2A DevTools などが使えればよし影響範囲
C2A Boom 環境