Make c2a-core repository as cargo workspace #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| [package] | ||
| name = "c2a-core" | ||
| version = "3.10.0" | ||
| version.workspace = true |
There was a problem hiding this comment.
workspace.package をとってくる，という意
meltingrabbit
approved these changes
Aug 1, 2023
|
conflict したので rebase（docs のファイル名変更） |
sksat
force-pushed
the
feature/cargo-workspace
branch
from
3c2979c to
aaba31e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
cargo workspace にする
Issue
詳細
今後
c2a-corecrate 以外の crate がこのリポジトリに導入されるため，cargo workspace にする影響範囲
c2a-corecrate など Rust 部分補足
resolver 2 を明示的に指定しているのは，rust-lang/cargo#5730 のような問題が発生する可能性があり，また， resolver 2 は opt-in であるため: https://doc.rust-lang.org/edition-guide/rust-2021/default-cargo-resolver.html#details