Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Applications dir to snake case #46

Merged
merged 7 commits into from
Aug 3, 2023

Conversation

sksat
Copy link
Member

@sksat sksat commented Aug 2, 2023

概要

Applications 以下のディレクトリを snake_case にする.また,src_user/Settings/Applications 以下のディレクトリも snake_case にする

Issue

@sksat sksat added the enhancement New feature or request label Aug 2, 2023
@sksat sksat self-assigned this Aug 2, 2023
@sksat
Copy link
Member Author

sksat commented Aug 3, 2023

migration script 書いた.src_user/Settings/Applications -> src_user/Settings/applications もやることにした

@sksat sksat requested a review from meltingrabbit August 3, 2023 00:29
@sksat sksat changed the title Rename apps dir to snake case Rename Applications dir to snake case Aug 3, 2023
@sksat
Copy link
Member Author

sksat commented Aug 3, 2023

@meltingrabbit レビューお願いします.あと,src_user/Settings 以下も同時に rename する,で問題ないかを確認したいです(他の snake_case rename にも関わるので)

@meltingrabbit
Copy link
Member

src_user/Settings/Applications 以下のディレクトリも snake_case にする

これは,実際のディレクトリのrenameではなく,コード上の (includeとか)文字列,って意味ですよね?(つまりuser配下の直接的な編集は別PR)

@sksat
Copy link
Member Author

sksat commented Aug 3, 2023

example user の更新は今までと同じように migration script を実行した別 PR です(migration script はこれまでと同じようにこの PR 上での実装です)

@meltingrabbit
Copy link
Member

OKそう.
user側のPRとあわせてapproveします

@sksat
Copy link
Member Author

sksat commented Aug 3, 2023

user 側 PR: #48

@sksat sksat merged commit 27e7ea7 into develop Aug 3, 2023
@sksat sksat deleted the feature/rename-apps-dir-to-snake-case branch August 3, 2023 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants