Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare package wasm crates #129

Merged
merged 3 commits into from
Apr 19, 2024
Merged

Prepare package wasm crates #129

merged 3 commits into from
Apr 19, 2024

Conversation

sksat
Copy link
Member

@sksat sksat commented Apr 18, 2024

概要

devtools-frontend/crates cargo workspace の crate に repository root と同じバージョンを設定する

変更の意図や背景

  • Invoke wasm-pack in wasm crate build script to package wasm into $OUT_DIR #127, Use dependency output wasm in cargo build #128devtools-frontend/crates の crate をフロントエンドのビルドにおいても Cargo で依存関係を管理するようにしたため、適切にバージョンなどを設定する
  • <repo>/Cargo.toml<repo/devtools-frontend/crates/Cargo.toml> でバージョンなどの二重管理が発生してしまうが、現状の Cargo の仕組み上この Cargo workspace をマージするのは無理があるため、この二重管理は許容するものとする
    • あとで2つの Cargo.toml をパースしてチェックするようなスクリプトを書いて Actions で走らせればよいと思う

発端となる Issue

@sksat sksat self-assigned this Apr 18, 2024
@sksat sksat requested a review from KOBA789 as a code owner April 18, 2024 12:26
@sksat
Copy link
Member Author

sksat commented Apr 18, 2024

@KOBA789 cargo package の実験のため、 #127, #128, #129 のマージ後、0.7.0-beta.4 のリリースをしたいです(wasm-opslang crate を追加で publish します)

@KOBA789
Copy link
Member

KOBA789 commented Apr 18, 2024

めちゃくちゃめんどくさいこというんですけど、publish するなら wasm-opslang より opslang-wasm の方が名前としてベターな気がしません?

Copy link
Member

@KOBA789 KOBA789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wasm-opslang の名前以外はよさそう

@sksat
Copy link
Member Author

sksat commented Apr 19, 2024

@KOBA789 名前に関しては同じ意見ではあるもののとりあえず最小限のパッチを出した、という状況なので、opslang-wasm でよいです

@sksat
Copy link
Member Author

sksat commented Apr 19, 2024

PR title 大きめにしてあるし、完全に同意見なのでここで変えちゃうか

@sksat sksat force-pushed the prepare-package-wasm-crates branch from 9b4a8a4 to e0b71e3 Compare April 19, 2024 03:19
@sksat sksat requested a review from KOBA789 April 19, 2024 03:21
Base automatically changed from use-dependency-output-wasm-in-cargo-build to main April 19, 2024 08:38
@KOBA789 KOBA789 merged commit c844a32 into main Apr 19, 2024
4 checks passed
@KOBA789 KOBA789 deleted the prepare-package-wasm-crates branch April 19, 2024 08:38
@sksat sksat added this to the v0.7.0 milestone Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants