This repository has been archived by the owner on Jan 4, 2023. It is now read-only.
fix(testy): improve testing flow #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tevariou
reviewed
Oct 15, 2021
tests/e2e/conftest.py
Outdated
|
|
||
| from . import settings | ||
|
|
||
| DATA_FIXTURES_DIR = Path(__file__).resolve().parent.parent / "fixtures" | ||
|
|
||
|
|
||
| def destroy_source(source): |
There was a problem hiding this comment.
we could just pass a name here and rename this to something like destroy_source_by_name since that's what this function is specificaly doing ? Or I don't know if it would just work to set autouse=True (with mimic_mapping as an argument) no need to call it in uploaded_mapping then
There was a problem hiding this comment.
you're right, I used a fixture instead!
tevariou
reviewed
Oct 15, 2021
|
|
||
|
|
||
| @pytest.fixture(scope="session") | ||
| def batch(uploaded_mapping): | ||
| # Send Patient and Encounter batch | ||
| batch = send_batch(uploaded_mapping) | ||
|
|
||
| while True: | ||
| start_time = time() | ||
| while time() < start_time + settings.BATCH_DURATION_TIMEOUT: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix many small issues on e2e tests:
failed_countersmechanism.Definition of Done
Tests
Launched e2e tests mulltiple times on testy