Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ (Kaggle LLM science exam): add kaggle notebooks #5

Merged
merged 4 commits into from
Dec 18, 2023
Merged

✨ (Kaggle LLM science exam): add kaggle notebooks #5

merged 4 commits into from
Dec 18, 2023

Conversation

louni-g
Copy link
Contributor

@louni-g louni-g commented Dec 11, 2023 •
edited
Loading

Fixes

Fixes #4

Technical details

Added the black profile for isort because I had conflicts between black and isort

Definition of Done

  • I followed the AI Code Book (I swear!).
  • I have added/updated tests according to my changes.
  • I have added/updated documentation according to my changes.

@louni-g louni-g marked this pull request as ready for review December 12, 2023 10:36
svensundell
svensundell approved these changes Dec 12, 2023
View reviewed changes
Copy link

@svensundell svensundell left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm thanks for that! Did you quicly ran the scripts to make sure we are managing correctly the dependencies with poetry? (just asking because i had numerous issues with installs but it was mostly just because of kaggle notebook)

@louni-g
Copy link
Contributor Author

louni-g commented Dec 13, 2023

Did you quicly ran the scripts to make sure we are managing correctly the dependencies with poetry? (just asking because i had numerous issues with installs but it was mostly just because of kaggle notebook)

No tbh I cleaned the code a bit but didn't try to re-run it so I'm not sure it works 100%, but it's just to store the code somewhere

simonmeoni
simonmeoni approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@simonmeoni simonmeoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✌️

@louni-g
Copy link
Contributor Author

louni-g commented Dec 13, 2023

I'll let you merge that once #3 is merged because this pr is based on it

@cjumel cjumel force-pushed the jumeoni/llm_kaggle branch from d1a25e5 to 9a786e6 Compare December 14, 2023 18:23
@cjumel cjumel force-pushed the jumeoni/llm_kaggle branch from 9a786e6 to d03aa76 Compare December 14, 2023 18:37
@cjumel cjumel force-pushed the jumeoni/llm_kaggle branch from d03aa76 to 5cd8717 Compare December 18, 2023 11:20
@cjumel cjumel force-pushed the jumeoni/llm_kaggle branch from 5cd8717 to 01d0523 Compare December 18, 2023 15:11
Base automatically changed from jumeoni/llm_kaggle to main December 18, 2023 15:12
@cjumel cjumel merged commit cd4a2bc into main Dec 18, 2023
1 check passed
@cjumel cjumel deleted the lg+sj/science_llm branch December 18, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svensundell svensundell svensundell approved these changes

@simonmeoni simonmeoni simonmeoni approved these changes

@cjumel cjumel Awaiting requested review from cjumel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Kaggle science exam experiments
4 participants
@louni-g @simonmeoni @svensundell @cjumel