Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Capacity Planning to use new OR1 instances #138

Merged
merged 3 commits into from
Dec 8, 2023
Merged

Conversation

chelma
Copy link
Collaborator

@chelma chelma commented Dec 7, 2023

Description

  • Swapped out data node instance types (r6g.12xlarge.search -> or1.8xlarge.search), as the new instance type offered some cost savings.

Tasks

Testing

  • Updated the unit tests; they still pass locally

License

I confirm that this contribution is made under an Apache 2.0 license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

Signed-off-by: Chris Helma <chelma+github@amazon.com>
@chelma chelma requested a review from awick December 7, 2023 16:30
@chelma
Copy link
Collaborator Author

chelma commented Dec 7, 2023

Hmm, looks like our testing GitHub Actions are broken. Will investigate.

@awick
Copy link
Contributor

awick commented Dec 7, 2023

you need to update ./manage_arkime/core/price_report.py also

Signed-off-by: Chris Helma <chelma+github@amazon.com>
Signed-off-by: Chris Helma <chelma+github@amazon.com>
Copy link
Contributor

@awick awick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chelma chelma merged commit 096afbe into main Dec 8, 2023
5 checks passed
@chelma chelma deleted the or1_instances branch December 8, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants