Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Essenty to 2.2.0-alpha02 #735

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Updated Essenty to 2.2.0-alpha02 #735

merged 1 commit into from
Jul 8, 2024

Conversation

arkivanov
Copy link
Owner

@arkivanov arkivanov commented Jul 8, 2024

Summary by CodeRabbit

  • Bug Fixes

    • Fixed state persistence in the card component to ensure data is retained correctly after configuration changes.
  • Dependencies

    • Updated essenty library to version 2.2.0-alpha02 for better performance and new experimental features.

Copy link

coderabbitai bot commented Jul 8, 2024

Walkthrough

The project underwent an update to the essenty dependency, moving from version 2.1.0 to 2.2.0-alpha02. This includes significant refactoring in the DefaultCardComponent.kt file, introducing experimental APIs and replacing Serializable with kotlinx.serialization.builtins.serializer. Additionally, the logic for instance retention and state saving was streamlined, removing the inner SavedState class and its associated constants.

Changes

Files Change Summary
deps.versions.toml Updated essenty dependency version to 2.2.0-alpha02 from 2.1.0.
.../cards/card/DefaultCardComponent.kt Refactored to use experimental APIs, updated serialization, and removed SavedState class along with constants.

Poem

In the code's quiet hum, a new dawn begins,
Essence updated, where alpha spins.
States retained, with experiments bold,
Refactored secrets in lines untold.
🎉✨ CodeRabbit hops with joy,
Through brighter verse, with code to deploy! 🌟🐇


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 170b65c and e674b87.

Files selected for processing (2)
  • deps.versions.toml (1 hunks)
  • sample/shared/shared/src/commonMain/kotlin/com/arkivanov/sample/shared/cards/card/DefaultCardComponent.kt (5 hunks)
Files skipped from review due to trivial changes (1)
  • deps.versions.toml
Additional comments not posted (2)
sample/shared/shared/src/commonMain/kotlin/com/arkivanov/sample/shared/cards/card/DefaultCardComponent.kt (2)

7-7: LGTM! Import changes are appropriate.

The new imports for ExperimentalInstanceKeeperApi, retainedInstance, ExperimentalStateKeeperApi, and kotlinx.serialization.builtins.serializer are necessary for the updated functionality.

Also applies to: 9-9, 11-12, 22-22


31-36: LGTM! Handler initialization changes are correct.

The updated approach using saveable with a serializer and retainedInstance is appropriate for state and instance management.

@arkivanov arkivanov merged commit d314f1d into master Jul 8, 2024
2 checks passed
@arkivanov arkivanov deleted the update-essenty branch July 8, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant