feat: improve astToString, add tests for astToString #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssalbdivad
approved these changes
Nov 5, 2023
There was a problem hiding this comment.
This is perfect- really impressive for a first PR that the attention to detail is so good 💯
I'm not sure what is going on with Node 20 on main, but I tested it on Node 18 and on beta Node 20 and both look fine so I'm going to bypass that check for now. Thanks again- happy to find another type-level issue for you to tackle anytime just let me know if you're interested 🎉
Merged
ahrjarrett
pushed a commit
to ahrjarrett/arktype-fork
that referenced
this pull request
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves astToString, some examples:
Before
After