Avoid unwrapping if inverse doesn't exist (#610)

* Avoid unwrapping if inverse doesn't exist * Update changelog.
arkworks-rs · Feb 24, 2023 · 744ed7e · 744ed7e
1 parent 9c62d3a
commit 744ed7e
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,7 @@
 ## Pending
 
 - (`ark-poly`) Reduce the number of field multiplications performed by `SparseMultilinearExtension::evaluate` and `DenseMultilinearExtension::evaluate`
+- [\#610](https://github.com/arkworks-rs/algebra/pull/610) (`ark-ec`) Fix panic in `final_exponentiation` step for MNT4/6 curves if inverse does not exist.
 
 ### Breaking changes
 

diff --git a/ec/src/models/mnt4/mod.rs b/ec/src/models/mnt4/mod.rs
@@ -60,7 +60,7 @@ pub trait MNT4Config: 'static + Sized {
 
     fn final_exponentiation(f: MillerLoopOutput<MNT4<Self>>) -> Option<PairingOutput<MNT4<Self>>> {
         let value = f.0;
-        let value_inv = value.inverse().unwrap();
+        let value_inv = value.inverse()?;
         let value_to_first_chunk =
             MNT4::<Self>::final_exponentiation_first_chunk(&value, &value_inv);
         let value_inv_to_first_chunk =

diff --git a/ec/src/models/mnt6/mod.rs b/ec/src/models/mnt6/mod.rs
@@ -61,7 +61,7 @@ pub trait MNT6Config: 'static + Sized {
 
     fn final_exponentiation(f: MillerLoopOutput<MNT6<Self>>) -> Option<PairingOutput<MNT6<Self>>> {
         let value = f.0;
-        let value_inv = value.inverse().unwrap();
+        let value_inv = value.inverse()?;
         let value_to_first_chunk =
             MNT6::<Self>::final_exponentiation_first_chunk(&value, &value_inv);
         let value_inv_to_first_chunk =